[RFC] Add hash_pbkdf2 function

On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara <ircmaxell@gmail.com> wrote:

That's very nice, indeed. One thing I'm wondering about is whether the last parameter could be changed from: raw_output = false To something like: output = "hex" (also allowing output = "raw", output = "base64") Just thinking that most of the time I'd prefer storing the hashed passwords as base64-encoded strings just because it's more compact, but this isn't a big deal, just a thought. Really nice work! Adam

hi Anthony! On Tue, Jun 19, 2012 at 1:14 AM, Anthony Ferrara <ircmaxell@gmail.com> wrote:

Very nice work! Thanks :) I would update the RFC with the current available algorithms or recommended to be used (depending on the usage or goal). About adding this to 5.4, I do not think it should be done. This is not a small change and it may require more testing, both for the implementations or the API (while it is fairly simple as of now :). php-next is next year anyway. Cheers,

Hi Anthony, i think your RFC is very good! I like the idea to have PBKDF2 implementation that is able to act, at the same time, as secure hash value generator (without the length parameter) and as key derivation function (with the length parameter). I think we should be consistent with the API of Hash functions of PHP and use the raw_output = false to generate hex string and raw_output = true to generate binary output. If folks need to convert the output to Base64 they can easily use base64_encode($output) where $output is generated with raw_output = true. I don't think this is a big deal. I also agree to insert this function in PHP 5.4, actually in this implementation we reused other hash functions of PHP and the tests for PBKDF2 are fully specified in PKCS #5 test vectors that you used in your patch test. Very nice job! Regards, Enrico 2012/6/19 Anthony Ferrara <ircmaxell@gmail.com>:

On Mon Jun 18 07:14 PM, Anthony Ferrara wrote:

I like this proposal, it could be useful to add a simpler api that has defaults matching the NIST recommendation: hash_password($password, $salt, $algo = 'sha1', $iterations = 1000); if the salt doesn't have at least 16 characters (128 bits), throw error internally this calls: hash_pbkdf2('sha1', $password, $salt, 1000); My point being that: $hash = hash_password('1234', 'my'. $password[1] . 'super-long-salt-secret'); Gives good enough security 80% of use cases and is simpler then: $hash = hash_pbkdf2('sha1', '1234', 'my'. $password[1] . 'super-long-salt-secret', 1000); Developers will still use sha1 or md5 because they are so simple.