[RFC] Constant Scalar Expressions (with constants)

> Hi Bob, > > thanks for your work, it’s awesome. One thing about constants: > > Take this example: > > const FOO = 2; > > class Klass > { > const FOO = 1; > const BAR = FOO; > } > > Here FOO is ambiguous, as it could resolve to 2 or to 1. If I understood > it correctly, global constants are not yet implemented but I would suggest > to always force prefixing the constant to get rid of the ambiguity and > allow for future extension. > > const FOO = 2; > > class Klass > { > const FOO = 1; > const BAR = self::FOO; > } > > Does that make sense? >

> Hi Bob, > > thanks for your work, it’s awesome. One thing about constants: > > Take this example: > > const FOO = 2; > > class Klass > { > const FOO = 1; > const BAR = FOO; > } > > Here FOO is ambiguous, as it could resolve to 2 or to 1. If I understood > it correctly, global constants are not yet implemented but I would suggest > to always force prefixing the constant to get rid of the ambiguity and > allow for future extension. > > const FOO = 2; > > class Klass > { > const FOO = 1; > const BAR = self::FOO; > } > > Does that make sense? >

> > cu, > Lars > > On 07 Nov 2013, at 13:01, Bob Weinand <bobwei9@hotmail.com> wrote: > > > Hi! > > > > As you all know, Anthony Ferrara had withdrawn his RFC a few months ago, > which was without support for constants in these expressions: > > > > const foo = 10; > > const bar = 10 * foo; > > > > The use of a constant in a declaration of a constant was not yet > possible with his patch. > > > > That's what I changed. > > > > Enjoy reading the RFC at: > > > > https://wiki.php.net/rfc/const_scalar_exprs > > > > Bob Weinand > > > > Special thanks go to Dmitry who had helped me a lot with feedback and a > deep review of the patch. > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > >

> Am 07.11.2013 13:01 schrieb "Bob Weinand" <bobwei9@hotmail.com>: > > > > https://wiki.php.net/rfc/const_scalar_exprs > > Wow, this looks really nice! > > Will this work with class autoloading, too? i.e. will > > class foo { > const X = bar::X; > } > > trigger autoloading for class bar? >

> On Thu, 7 Nov 2013, Bob Weinand wrote: >> Hi! >> >> As you all know, Anthony Ferrara had withdrawn his RFC a few months ago, which was without support for constants in these expressions: >> >> const foo = 10; >> const bar = 10 * foo; >> >> The use of a constant in a declaration of a constant was not yet possible with his patch. >> >> That's what I changed. >> >> Enjoy reading the RFC at: >> >> https://wiki.php.net/rfc/const_scalar_exprs > > https://github.com/bwoebi/php-src/compare/const_scalar_exprs#diff-4d0b93094aafe8cf519b4f0a3322f471L590 > > -#define IS_CALLABLE 10 > +#define IS_CONSTANT_AST 10 > +#define IS_CALLABLE 11 > > Can I please suggest that you do not change existing constant values? > You're using a macro to check for the constant type anyway, so you can > do the complex checking for constant types in there.

> I'm also of the opinion that just " This can allow for writing far > easier to understand code, by allowing for far more expressive code." is > by far not enough of a justification for a syntax addition. Please > please try to be convincing by having good arguments, presenting > alternatives and cons.