Everything

php

[RFC] Improved Error Callback Mechanism

php.internals

Patrick ALLAERT

11 years ago

Hi Internals,

This email is to inform you that Olivier and I have opened for discussion a
new RFC in order, for PHP extensions authors, to hook more easily into the
default error handler callback:

https://wiki.php.net/rfc/improved_error_callback_mechanism

There is zero new feature for the users, nor any BC break. The changes made
to the engine are for PHP extensions developers changing the behaviour of
php_error_cb via zend_error_cb. Currently, supporting multiple extensions
that want to hook into it requires very hacky solutions to coexists.

We hope this would still be possible for PHP 7.0 as this is only about
providing more (useful) hooks and wish we could start voting on it on March
20th.

Cheers and thanks in advance,
Patrick

Olivier Garcia

11 years ago

Greetings Internals,

A few weeks ago, Patrick (patrickallaert@php.net) and I wrote a RFC
[1] to improve the error callback mechanism and we just submitted a
patch [2] - mostly written by Patrick - for review.

Since our patch only modifies PHP's inner working and does nothing on
the userland, we think it could be merged in PHP 7 and that the vote
could be done using the 50% + 1 rule.
Feel free to tell us if you're uncomfortable with it.

If no problem is reported, we'll open the vote next week.

Kind regards

[1] https://wiki.php.net/rfc/improved_error_callback_mechanism
[2] https://github.com/php/php-src/pull/1247

--
Olivier Garcia

Benjamin Eberlei

11 years ago

On Fri, Apr 24, 2015 at 12:24 PM, Olivier Garcia <oliviergarcia@php.net>
wrote:

> Greetings Internals,
>
> A few weeks ago, Patrick (patrickallaert@php.net) and I wrote a RFC
> [1] to improve the error callback mechanism and we just submitted a
> patch [2] - mostly written by Patrick - for review.
>
> Since our patch only modifies PHP's inner working and does nothing on
> the userland, we think it could be merged in PHP 7 and that the vote
> could be done using the 50% + 1 rule.
> Feel free to tell us if you're uncomfortable with it.
>
> If no problem is reported, we'll open the vote next week.
>

I am very much in favour of this RFC. Hooking into the error handlers is a
bit tricky right now when you have to assume that xdebug fiddles with your
own hook.

Jakub Kubíček

11 years ago

+1 for this.

Best regards,
Kubo2

2015-04-24 15:10 GMT+02:00 Benjamin Eberlei <kontakt@beberlei.de>: