PR1739

php.internals

Yasuo Ohgaki

10 years ago
Hi Anatol, https://github.com/php/php-src/pull/1739 This PR is good one. It opens handler first, then proceeds. It fixes save handler crash also. The PR does not break our tests and PHP7 only fix. However, It changes handler execution order. This change will not affect normal operation/code at all, but user's unit tests may detect the difference as we had already. Would you like to include this PR in released version? My opinion is +1 for applying this. Regards,
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
Hi Anatol, On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > https://github.com/php/php-src/pull/1739 > This PR is good one. It opens handler first, then proceeds. > It fixes save handler crash also. > > The PR does not break our tests and PHP7 only fix. However, It changes > handler execution order. This change will not affect normal > operation/code at all, but user's unit tests may detect the difference > as we had already. > > Would you like to include this PR in released version? > My opinion is +1 for applying this.
It's committed to master 46d4a371054f43fe8aeca14b83ba722adc84ac10 If you decide merge it, please cherry pick. Thank you.
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
Hi Anatol, On Thu, Jan 28, 2016 at 1:33 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: >> >> https://github.com/php/php-src/pull/1739 >> This PR is good one. It opens handler first, then proceeds. >> It fixes save handler crash also. >> >> The PR does not break our tests and PHP7 only fix. However, It changes >> handler execution order. This change will not affect normal >> operation/code at all, but user's unit tests may detect the difference >> as we had already. >> >> Would you like to include this PR in released version? >> My opinion is +1 for applying this. > > It's committed to master > 46d4a371054f43fe8aeca14b83ba722adc84ac10 > > If you decide merge it, please cherry pick. > Thank you.
I missed to include my error message change 99101ba31019e3b19e4cf3feaf163aeffb8a398c In case you pick up this. Please pick this, too. I made patch for work around patch. https://gist.github.com/yohgaki/2a19756978837e4dd07c It's a little dirty compare to master fix, but this works also. Regards,
-- Yasuo Ohgaki yohgaki@ohgaki.net