[RFC Discussion] Precise session management

php.internals

Yasuo Ohgaki

10 years ago
Hi all, It's been long time since the first proposal. Since session module is important module for Web apps, I would like to hear opinions for this RFC once again before vote. RFC https://wiki.php.net/rfc/precise_session_management PR https://github.com/php/php-src/pull/1734 Thank you.
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
Hi all, On Sun, Feb 14, 2016 at 9:49 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > It's been long time since the first proposal. Since session > module is important module for Web apps, I would like to > hear opinions for this RFC once again before vote. > > RFC > https://wiki.php.net/rfc/precise_session_management > > PR > https://github.com/php/php-src/pull/1734
Thank you for the comment and review, Bob! I've updated the patch. Please take a look at the PR. I haven't changed E_RECOVERABLE_ERROR to exception yet. Anyone has opinion on this? If not, I'll convert the error to exception and start vote. Regards,
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
Hi all, On Fri, Feb 26, 2016 at 4:09 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> I haven't changed E_RECOVERABLE_ERROR to exception yet. > Anyone has opinion on this? If not, I'll convert the error to exception > and start vote.
I would like to ask what kind of exception should be raised. Currently, we have http://lxr.php.net/search?q=zend_throw_exception&defs=&refs=&path=&hist=&project=PHP_MASTER Any suggestion? I don't have particular preference. I'll use null NULL ce if there is no comment. Regards,
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
Hi all, On Fri, Feb 26, 2016 at 4:09 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>> >> RFC >> https://wiki.php.net/rfc/precise_session_management >> >> PR >> https://github.com/php/php-src/pull/1734 > > Thank you for the comment and review, Bob! > I've updated the patch. Please take a look at the PR. > > I haven't changed E_RECOVERABLE_ERROR to exception yet. > Anyone has opinion on this? If not, I'll convert the error to exception > and start vote.
I pushed patch that converts E_RECOVERABLE_ERROR to zend_throw_exception*. I'll wait a few days for review and start vote. Thank you.
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
Hi all, On Sun, Feb 14, 2016 at 9:49 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> It's been long time since the first proposal. Since session > module is important module for Web apps, I would like to > hear opinions for this RFC once again before vote. > > RFC > https://wiki.php.net/rfc/precise_session_management > > PR > https://github.com/php/php-src/pull/1734 > > Thank you.
Vote is over and the result is 15 in favor and 11 against. It's over half of votes, but I set 2/3 to pass, so we have to come up to other solution for current session management problems. I'm looking forward to hear alternatives from people vote against this RFC. Issues are - Prevent race conditions. - Prevent session data from abuse. (Stolen session including forever) These are allowed with current session module. Thank you!
-- Yasuo Ohgaki yohgaki@ohgaki.net

Yasuo Ohgaki

10 years ago
On Thu, Mar 24, 2016 at 11:26 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> On Sun, Feb 14, 2016 at 9:49 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: >> It's been long time since the first proposal. Since session >> module is important module for Web apps, I would like to >> hear opinions for this RFC once again before vote. >> >> RFC >> https://wiki.php.net/rfc/precise_session_management >> >> PR >> https://github.com/php/php-src/pull/1734 >> >> Thank you. > > Vote is over and the result is 15 in favor and 11 against. > It's over half of votes, but I set 2/3 to pass, so we have to come up > to other solution for current session management problems. > > I'm looking forward to hear alternatives from people vote against this RFC. > > Issues are > - Prevent race conditions. > - Prevent session data from abuse. (Stolen session including forever) > > These are allowed with current session module. > > Thank you!
I sent new mail for alternative implementation. Please comment to new thread. Thank you.
-- Yasuo Ohgaki yohgaki@ohgaki.net