Everything

php

[RFC] Add IntlTimeZone::getWindowsID() and IntlTimeZone::getIDForWindowsID() to ext/intl

php.internals

Sara Golemon

10 years ago

Pretty basic RFC: There's new methods in ICU 52, wrap 'em up and make
'em available.
Note that despite these APIs being windows focused, they are in fact
available on Linux.
They're just a database lookup, essentially.
https://wiki.php.net/rfc/intl.timezone.get-windows-id

-Sara

P.S. - Yes, tests are coming along before we get to voting.  :)

Stas Malyshev

10 years ago

Hi!

> Pretty basic RFC: There's new methods in ICU 52, wrap 'em up and make
> 'em available.
> Note that despite these APIs being windows focused, they are in fact
> available on Linux.
> They're just a database lookup, essentially.
> https://wiki.php.net/rfc/intl.timezone.get-windows-id

Looks pretty straightforward, and these are pretty simple, not even sure
we need RFC for such small incremental additions, but in any case, let's
do it :)

--
Stas Malyshev
smalyshev@gmail.com

Sara Golemon

10 years ago

On Wed, Mar 16, 2016 at 2:58 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:

>> Pretty basic RFC: There's new methods in ICU 52, wrap 'em up and make
>> 'em available.
>> Note that despite these APIs being windows focused, they are in fact
>> available on Linux.
>> They're just a database lookup, essentially.
>> https://wiki.php.net/rfc/intl.timezone.get-windows-id
>
> Looks pretty straightforward, and these are pretty simple, not even sure
> we need RFC for such small incremental additions, but in any case, let's
> do it :)
>

Yeah, I was tempted to just merge it and wait for someone to complain.
But that's no way to embrace openness.  Besides, no rush to avoid the
delay for voting. :p

-Sara

Larry Garfield

10 years ago

On 3/16/16 5:16 PM, Sara Golemon wrote:

> On Wed, Mar 16, 2016 at 2:58 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
>>> Pretty basic RFC: There's new methods in ICU 52, wrap 'em up and make
>>> 'em available.
>>> Note that despite these APIs being windows focused, they are in fact
>>> available on Linux.
>>> They're just a database lookup, essentially.
>>> https://wiki.php.net/rfc/intl.timezone.get-windows-id
>> Looks pretty straightforward, and these are pretty simple, not even sure
>> we need RFC for such small incremental additions, but in any case, let's
>> do it :)
>>
> Yeah, I was tempted to just merge it and wait for someone to complain.
> But that's no way to embrace openness.  Besides, no rush to avoid the
> delay for voting. :p
>
> -Sara
>

If it works on Linux just fine, why is it called Windows?  Is that
really what the ICU spec says to call them, rather than something
meaningful?  (That would be sad making if so.)

--
--Larry Garfield

Lester Caine

10 years ago

On 16/03/16 22:20, Larry Garfield wrote:

> If it works on Linux just fine, why is it called Windows?  Is that
> really what the ICU spec says to call them, rather than something
> meaningful?  (That would be sad making if so.)

Simples ...
http://stackoverflow.com/questions/17348807/how-to-translate-between-windows-and-iana-time-zones

--
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk

Sara Golemon

10 years ago

On Wed, Mar 16, 2016 at 3:20 PM, Larry Garfield <larry@garfieldtech.com> wrote:

> If it works on Linux just fine, why is it called Windows?  Is that really
> what the ICU spec says to call them, rather than something meaningful?
> (That would be sad making if so.)
>

Because there's no "spec" as such for the names that Windows uses for
Timezones, they're just "The names that windows uses", so in an effort
to give them a categorical name, they're called.... windows IDs.

And yes, that's what ICU calls them, e.g.
icu::TimeZone::getWindowsID() <--- That's an ICU API.

-Sara

Trevor Suarez

10 years ago

I just wanted to personally thank Sara Golemon, and the PHP internals team,
for being so incredibly approachable, open, and all-around awesome.

The fact that a simple, informal tweet can turn into a core feature is
incredible: https://twitter.com/trevorsuarez/status/709864419753377792

Thanks again!
- Trevor