Everything

php

Home » Project » Newsgroups » php.internals » [VOTE] IntlTimeZone::getWindowsID() and getIDForWindowsID() »

[VOTE] IntlTimeZone::getWindowsID() and getIDForWindowsID()

php.internals

Sara Golemon

10 years ago

Opening vote on
https://wiki.php.net/rfc/intl.timezone.get-windows-id#vote at
2016-04-01 01:37 UTC.
Vote will close in two weeks: 2016-04-15 23:59 UTC

-Sara

Derick Rethans

10 years ago

On Thu, 31 Mar 2016, Sara Golemon wrote:

> Opening vote on
> https://wiki.php.net/rfc/intl.timezone.get-windows-id#vote at
> 2016-04-01 01:37 UTC.
> Vote will close in two weeks: 2016-04-15 23:59 UTC

I think the RFC misses that either mapping might not work, and hence can
not always return a string. The code handles it correctly by returning
false though. Make sure this ends up in the documentation though :-)

cheers,
Derick

--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
Posted with an email client that doesn't mangle email: alpine

Sara Golemon

10 years ago

On Mon, Apr 4, 2016 at 2:52 AM, Derick Rethans <derick@php.net> wrote:

>> https://wiki.php.net/rfc/intl.timezone.get-windows-id#vote at
>
> I think the RFC misses that either mapping might not work, and hence can
> not always return a string. The code handles it correctly by returning
> false though. Make sure this ends up in the documentation though :-)
>

Fair point.  I revised the text of the RFC to reflect returning FALSE
on failure.