Enable Zend Signals by Default

php.internals

Dmitry Stogov

10 years ago
Hi, I'm going to enable Zend-Signals subsystem by default. With "Zend signals" enabled, we would have safe termination signal handling in opcache, that would prevent staying SHM in inconsistent state, in cost of few additional checks on each opcache SHM update (performance impact is negligible). Zend Signals were originally designed to safely handle execution timeout and other termination signals. However, termination signals were never handled by OPcache (only by APC). Also, introduction of "safe execution timeout" handling made a lot of checks in Zend Engine redundant. Today, I already removed useless checks in ZE, added other checks in OPcahce, and fixed few compatibility problems. This, actually, didn't change anything with "zend signals" disabled. https://github.com/php/php-src/pull/1951 So, I propose to switch zend-signals on, and revert back if it makes problems to 7.1 release process. Any objections? Thanks. Dmitry.

Rasmus Lerdorf

10 years ago
On Mon, Jun 20, 2016 at 1:25 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> So, I propose to switch zend-signals on, and revert back if it makes > problems to 7.1 release process. > Any objections?
No objections here. I have been hitting annoying segfaults in 7.0 that will likely be helped by this. -Rasmus

Xinchen Hui

10 years ago
Hey: On Tue, Jun 21, 2016 at 9:02 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> On Mon, Jun 20, 2016 at 1:25 PM, Dmitry Stogov <dmitry@zend.com> wrote: > > So, I propose to switch zend-signals on, and revert back if it makes > problems to 7.1 release process. > Any objections? > > > No objections here. I have been hitting annoying segfaults in 7.0 that > will likely be helped by this. >
No objections here neither, I already tried enable it in 7.0 :) thanks
> > -Rasmus >
-- Xinchen Hui @Laruence http://www.laruence.com/