Bundled SQLlite3

php.internals

Christoph Becker

10 years ago
Hi! What's our stance on updating the bundled SQLite3? Currently the PHP-5.6 and 7.0 branch have 3.8.10.2, while the PHP-7.1 and master branch have 3.9.2 (sqlite3.h) respectively 3.13.0 (sqlite3.c). The latter would have certainly to be fixed to be consistent, but I have some doubts regarding sticking with old SQLite3 versions for supported PHP versions. After all, all minor versions at least as of SQLite 3.9.0 are "regularly scheduled maintenance releases"[1], and it appears that no bug-fixes will be published for non-current minor versions. Thoughts? [1] <http://sqlite.org/news.html>
-- Christoph M. Becker

Anatol Belski

10 years ago
Hi Christoph,
> -----Original Message----- > From: Christoph Becker [mailto:cmbecker69@gmx.de] > Sent: Monday, July 25, 2016 12:49 AM > To: internals@lists.php.net > Subject: [PHP-DEV] Bundled SQLlite3 > > Hi! > > What's our stance on updating the bundled SQLite3? > > Currently the PHP-5.6 and 7.0 branch have 3.8.10.2, while the PHP-7.1 and > master branch have 3.9.2 (sqlite3.h) respectively 3.13.0 (sqlite3.c). The latter > would have certainly to be fixed to be consistent, but I have some doubts > regarding sticking with old SQLite3 versions for supported PHP versions. After all, > all minor versions at least as of SQLite 3.9.0 are "regularly scheduled > maintenance releases"[1], and it appears that no bug-fixes will be published for > non-current minor versions. >
Normally it is ok to upgrade the bundled libsqlite. When done carefully, even in the stable branch. Fe from the news you've linked - "Yikes! The 3.12.0 and 3.12.1 releases contain a backwards compatibility bug!" :) But similar situations already happened before. However not upgrading it at all for 3 years is also not good, so fine with upgrading it from time to time. A respective RM should be better asked for approval. Regards Anatol

Davey

10 years ago
I'd like to see an updated SQLite in 7.1, this is part of shoring up the stability of the release IMO. - Davey On Sun, Jul 24, 2016 at 11:57 PM, Anatol Belski <anatol.php@belski.net> wrote:

Christoph Becker

10 years ago
On 25.07.2016 at 09:11, Davey Shafik wrote:
> I'd like to see an updated SQLite in 7.1, this is part of shoring up the > stability of the release IMO.
Thanks, Anatol and Davey for the fast reply. After having a closer look at the release news, it seems that there have been no major bugs in 3.8.10.2, and that release is not so old (2015-05-20), so I leave 5.6 and 7.0 as is. 7.1 and master should, however, be fixed (i.e. update of sqlite3.h and sqlite3ext.h to 3.13.0). Done with <https://github.com/php/php-src/commit/ee07e23>. I'll try to keep an eye on SQLite3 wrt. new releases and possibly necessary updates in PHP.
> On Sun, Jul 24, 2016 at 11:57 PM, Anatol Belski <anatol.php@belski.net> > wrote: > >> Hi Christoph, >> >>> -----Original Message----- >>> From: Christoph Becker [mailto:cmbecker69@gmx.de] >>> Sent: Monday, July 25, 2016 12:49 AM >>> To: internals@lists.php.net >>> Subject: [PHP-DEV] Bundled SQLlite3 >>> >>> Hi! >>> >>> What's our stance on updating the bundled SQLite3? >>> >>> Currently the PHP-5.6 and 7.0 branch have 3.8.10.2, while the PHP-7.1 and >>> master branch have 3.9.2 (sqlite3.h) respectively 3.13.0 (sqlite3.c). >> The latter >>> would have certainly to be fixed to be consistent, but I have some doubts >>> regarding sticking with old SQLite3 versions for supported PHP >> versions. After all, >>> all minor versions at least as of SQLite 3.9.0 are "regularly scheduled >>> maintenance releases"[1], and it appears that no bug-fixes will be >> published for >>> non-current minor versions. >>> >> Normally it is ok to upgrade the bundled libsqlite. When done carefully, >> even in the stable branch. Fe from the news you've linked - "Yikes! The >> 3.12.0 and 3.12.1 releases contain a backwards compatibility bug!" :) But >> similar situations already happened before. However not upgrading it at all >> for 3 years is also not good, so fine with upgrading it from time to time. >> A respective RM should be better asked for approval. >> >> Regards >> >> Anatol
-- Christoph M. Becker

Anatol Belski

10 years ago
> -----Original Message----- > From: Christoph Becker [mailto:cmbecker69@gmx.de] > Sent: Monday, July 25, 2016 10:30 AM > To: Davey Shafik <davey@php.net>; Anatol Belski <anatol.php@belski.net> > Cc: internals@lists.php.net; Ferenc Kovacs <tyrael@php.net> > Subject: Re: [PHP-DEV] Bundled SQLlite3 > > On 25.07.2016 at 09:11, Davey Shafik wrote: > > > I'd like to see an updated SQLite in 7.1, this is part of shoring up > > the stability of the release IMO. > > Thanks, Anatol and Davey for the fast reply. > > After having a closer look at the release news, it seems that there have been no > major bugs in 3.8.10.2, and that release is not so old (2015-05-20), so I leave 5.6 > and 7.0 as is. >
For 7.0 it should be fine as well, I guess. I just meant it's usually enough to ask the RM of the lowest branch, as then it'll have to be merged up anyway. Thanks Anatol

Christoph Becker

10 years ago
On 25.07.2016 at 17:36, Anatol Belski wrote:
>> -----Original Message----- >> From: Christoph Becker [mailto:cmbecker69@gmx.de] >> Sent: Monday, July 25, 2016 10:30 AM >> To: Davey Shafik <davey@php.net>; Anatol Belski <anatol.php@belski.net> >> Cc: internals@lists.php.net; Ferenc Kovacs <tyrael@php.net> >> Subject: Re: [PHP-DEV] Bundled SQLlite3 >> >> On 25.07.2016 at 09:11, Davey Shafik wrote: >> >>> I'd like to see an updated SQLite in 7.1, this is part of shoring up >>> the stability of the release IMO. >> >> Thanks, Anatol and Davey for the fast reply. >> >> After having a closer look at the release news, it seems that there have been no >> major bugs in 3.8.10.2, and that release is not so old (2015-05-20), so I leave 5.6 >> and 7.0 as is. >> > For 7.0 it should be fine as well, I guess. I just meant it's usually enough to ask the RM of the lowest branch, as then it'll have to be merged up anyway.
Okay, so I have updated PHP-7.0 to SQLite3 3.13.0, see <http://git.php.net/?p=php-src.git;a=commit;h=81c25ab>.
-- Christoph M. Becker