RE: [PHP-CVS] com php-src: Add stdin command and -s command line parameter to phpdbg: run-tests.php sapi/phpdbg/phpdbg.c sapi/phpdbg/phpdbg_bp.c sapi/phpdbg/phpdbg_bp.h sapi/phpdbg/phpdbg_help.c sapi/phpdbg/phpdbg_list.c sapi/phpdbg/phpdbg_prompt.c s

php.internals

Anatol Belski

9 years ago
Hi Bob,
> -----Original Message----- > From: Bob Weinand [mailto:bwoebi@php.net] > Sent: Wednesday, October 12, 2016 8:16 PM > To: php-cvs@lists.php.net > Subject: [PHP-CVS] com php-src: Add stdin command and -s command line > parameter to phpdbg: run-tests.php sapi/phpdbg/phpdbg.c > sapi/phpdbg/phpdbg_bp.c sapi/phpdbg/phpdbg_bp.h > sapi/phpdbg/phpdbg_help.c sapi/phpdbg/phpdbg_list.c > sapi/phpdbg/phpdbg_prompt.c sapi/phpdb > > Commit: 5aae01104f88f98f42fd997d360757651f7cc919 > Author: Bob Weinand <bobwei9@hotmail.com> Wed, 12 Oct 2016 > 20:11:51 +0200 > Parents: 74b5662536ccdf9b7b02c495f02a27c64e27fff7 > Branches: PHP-7.0 > > Link: http://git.php.net/?p=php- > src.git;a=commitdiff;h=5aae01104f88f98f42fd997d360757651f7cc919 > > Log: > Add stdin command and -s command line parameter to phpdbg > > This allows reading the initial script file from stdin instead of being forced to put > the script into a file in order to run it with phpdbg. > Especially important for programmatic execution of phpdbg. > > Also adding tests/include_once.phpt and tests/set_exception_handler.phpt as I > seem to have forgotten to git add them sometime long ago... > > Changed paths: > M run-tests.php > M sapi/phpdbg/phpdbg.c > M sapi/phpdbg/phpdbg_bp.c > M sapi/phpdbg/phpdbg_bp.h > M sapi/phpdbg/phpdbg_help.c > M sapi/phpdbg/phpdbg_list.c > M sapi/phpdbg/phpdbg_prompt.c > M sapi/phpdbg/phpdbg_prompt.h > A sapi/phpdbg/tests/include_once.phpt > A sapi/phpdbg/tests/set_exception_handler.phpt > A sapi/phpdbg/tests/stdin_001.phpt
This patch contains at least one API breach -PHPDBG_API void phpdbg_set_breakpoint_file(const char *path, long line_num) /* {{{ */ +PHPDBG_API void phpdbg_set_breakpoint_file(const char *path, size_t path_len, long line_num) /* {{{ */ Please fix it for 7.0 at least. Also zend_strpprintf is not exported on Windows, so the build there is broken. Thanks.