Everything

php

Deprecate INTL_IDNA_VARIANT_2003

php.internals

Christoph Becker

9 years ago

Hi!

I've just noticed that ICU has deprecated the IDNA 2003 related
functions as of ICU 55[1].  Therefore I suggest that we deprecate
INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the
default as of PHP 8.0(?) (or even remove this parameter?), and remove
INT_IDNA_VARIANT_2003 as of PHP 8.0.  Otherwise we may get into trouble
if ICU removes these functions.

Thoughts?  Does this change require an RFC?

[1]
<http://source.icu-project.org/repos/icu/icu/tags/release-55-1/APIChangeReport.html#deprecated>

--
Christoph M. Becker

Niklas Keller

9 years ago

2016-11-24 19:25 GMT+01:00 Christoph M. Becker <cmbecker69@gmx.de>:

> Hi!
>
> I've just noticed that ICU has deprecated the IDNA 2003 related
> functions as of ICU 55[1].  Therefore I suggest that we deprecate
> INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the
> default as of PHP 8.0(?) (or even remove this parameter?), and remove
> INT_IDNA_VARIANT_2003 as of PHP 8.0.  Otherwise we may get into trouble
> if ICU removes these functions.
>
> Thoughts?  Does this change require an RFC?

Please update the defaults for e.g.
http://php.net/manual/en/function.idn-to-ascii.php, too. A default call
shouldn't result in a deprecation notice IMO.

Christoph Becker

9 years ago

On 13.05.2017 at 17:14, Niklas Keller wrote:

> 2016-11-24 19:25 GMT+01:00 Christoph M. Becker <cmbecker69@gmx.de>:
>
>> I've just noticed that ICU has deprecated the IDNA 2003 related
>> functions as of ICU 55[1].  Therefore I suggest that we deprecate
>> INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the
>> default as of PHP 8.0(?) (or even remove this parameter?), and remove
>> INT_IDNA_VARIANT_2003 as of PHP 8.0.  Otherwise we may get into trouble
>> if ICU removes these functions.
>>
>> Thoughts?  Does this change require an RFC?
>
> Please update the defaults for e.g.
> http://php.net/manual/en/function.idn-to-ascii.php, too. A default call
> shouldn't result in a deprecation notice IMO.

Changing the defaults in PHP 7.4 first has been part of the accepted
RFC, see
<https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003>.

--
Christoph M. Becker

lists@rhsoft.net

9 years ago

Am 13.05.2017 um 17:30 schrieb Christoph M. Becker:

> On 13.05.2017 at 17:14, Niklas Keller wrote:
>
>> 2016-11-24 19:25 GMT+01:00 Christoph M. Becker <cmbecker69@gmx.de>:
>>
>>> I've just noticed that ICU has deprecated the IDNA 2003 related
>>> functions as of ICU 55[1].  Therefore I suggest that we deprecate
>>> INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the
>>> default as of PHP 8.0(?) (or even remove this parameter?), and remove
>>> INT_IDNA_VARIANT_2003 as of PHP 8.0.  Otherwise we may get into trouble
>>> if ICU removes these functions.
>>>
>>> Thoughts?  Does this change require an RFC?
>>
>> Please update the defaults for e.g.
>> http://php.net/manual/en/function.idn-to-ascii.php, too. A default call
>> shouldn't result in a deprecation notice IMO.
>
> Changing the defaults in PHP 7.4 first has been part of the accepted
> RFC, see
> <https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003>.

then supress the deprecation warning in case it's the internal default

enforce people changing their PHP code which relies on "well, normally
the defaults should just work" is doomed - in the next iteration a few
years later you have to touch it again *because* of that

Niklas Keller

9 years ago

2017-05-13 17:30 GMT+02:00 Christoph M. Becker <cmbecker69@gmx.de>:

> On 13.05.2017 at 17:14, Niklas Keller wrote:
>
> > 2016-11-24 19:25 GMT+01:00 Christoph M. Becker <cmbecker69@gmx.de>:
> >
> >> I've just noticed that ICU has deprecated the IDNA 2003 related
> >> functions as of ICU 55[1].  Therefore I suggest that we deprecate
> >> INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the
> >> default as of PHP 8.0(?) (or even remove this parameter?), and remove
> >> INT_IDNA_VARIANT_2003 as of PHP 8.0.  Otherwise we may get into trouble
> >> if ICU removes these functions.
> >>
> >> Thoughts?  Does this change require an RFC?
> >
> > Please update the defaults for e.g.
> > http://php.net/manual/en/function.idn-to-ascii.php, too. A default call
> > shouldn't result in a deprecation notice IMO.
>
> Changing the defaults in PHP 7.4 first has been part of the accepted
> RFC, see
> <https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003>.

I've missed that, could we please have a follow-up RFC that changes that to
7.2? I don't see a reason to touch it twice.

Regards, Niklas

Christoph Becker

9 years ago

On 14.05.2017 at 09:41, Niklas Keller wrote:

> 2017-05-13 17:30 GMT+02:00 Christoph M. Becker <cmbecker69@gmx.de>:
>
>> On 13.05.2017 at 17:14, Niklas Keller wrote:
>>
>>> 2016-11-24 19:25 GMT+01:00 Christoph M. Becker <cmbecker69@gmx.de>:
>>>
>>>> I've just noticed that ICU has deprecated the IDNA 2003 related
>>>> functions as of ICU 55[1].  Therefore I suggest that we deprecate
>>>> INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the
>>>> default as of PHP 8.0(?) (or even remove this parameter?), and remove
>>>> INT_IDNA_VARIANT_2003 as of PHP 8.0.  Otherwise we may get into trouble
>>>> if ICU removes these functions.
>>>>
>>>> Thoughts?  Does this change require an RFC?
>>>
>>> Please update the defaults for e.g.
>>> http://php.net/manual/en/function.idn-to-ascii.php, too. A default call
>>> shouldn't result in a deprecation notice IMO.
>>
>> Changing the defaults in PHP 7.4 first has been part of the accepted
>> RFC, see
>> <https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003>.
>
> I've missed that, could we please have a follow-up RFC that changes that to
> 7.2? I don't see a reason to touch it twice.

Not changing the default in PHP 7.2 has been suggested by Sara[1], and
it was part of the vote, so I don't think a follow-up RFC would be in
order.  If you think otherwise, feel free to submit a new RFC. :)

[1] <http://news.php.net/php.internals/97571>

--
Christoph M. Becker

Niklas Keller

9 years ago

>
> Not changing the default in PHP 7.2 has been suggested by Sara[1], and
> it was part of the vote, so I don't think a follow-up RFC would be in
> order.  If you think otherwise, feel free to submit a new RFC. :)
>
> [1] <http://news.php.net/php.internals/97571>

It was part of the RFC, but no vote option or something like that.

@Sara: What's your current stance on this?

Regards, Niklas