On Dec 1, 2016 12:46 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> On Dec 1, 2016 12:21 PM, Bob Weinand <bobwei9@hotmail.com> wrote:
> >
> >
> >> Am 01.12.2016 um 08:15 schrieb Dmitry Stogov <dmitry@zend.com>:
> >>
> >> Hi,
> >>
> >> I see, the patch is merged, but I didn't see Nikita's opinion and agreement.
> >> Nikita, did you give a green light to this?
> >>
> >> 1) The latest changes to FE_RESET (especially in CFG construction) look weird (labels don't match to basic blocks).
> >
> >
> > Quoting Nikita (Stackoverflow chat):
> > > I can't think of anything where it would cause problems right now -- just a bit uncomfortable with the CFG being inaccurate.
> >
> > I am open for any better fixes to that, though Nikita had no much better patch immediately ready either.
This is a critical problem.
You broke quite complex part of the code.
I'm going to revert the patch, and then review/rework/recommit it part by part.
Thanks. Dmitry.
