Re: [Discussion] HKDF

php.internals

Tom Worster

9 years ago
Hi Andrey, Is there a draft of end-user docs for the PHP function? Tom

Andrey Andreev

9 years ago
Hi Tom, On Wed, Jan 11, 2017 at 9:16 PM, Tom Worster <fsb@thefsb.org> wrote:
> Hi Andrey, > > Is there a draft of end-user docs for the PHP function? >
No, not yet. But naturally, I do promise to write the docs + a userland compat package. In fact, I have some other docs updates that I want to do, so I might as well request VCS access for that ... the docs still being in SVN has been kind of demotivating. Cheers, Andrey.

Kalle Sommer Nielsen

9 years ago
Hi Andrey 2017-01-11 20:39 GMT+01:00 Andrey Andreev <narf@devilix.net>:
> But naturally, I do promise to write the docs + a userland compat package. > In fact, I have some other docs updates that I want to do, so I might as > well request VCS access for that ... the docs still being in SVN has been > kind of demotivating.
You can use the online editor[1] and submit a patch as well. You'll find the relevant documentation for ext/hash in: en/reference/hash/functions/ [1] http://edit.php.net/
-- regards, Kalle Sommer Nielsen kalle@php.net

Andrey Andreev

9 years ago
Hi Kalle, On Wed, Jan 11, 2017 at 10:38 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:
> Hi Andrey > > 2017-01-11 20:39 GMT+01:00 Andrey Andreev <narf@devilix.net>: > > But naturally, I do promise to write the docs + a userland compat > package. > > In fact, I have some other docs updates that I want to do, so I might as > > well request VCS access for that ... the docs still being in SVN has been > > kind of demotivating. > > You can use the online editor[1] and submit a patch as well. You'll > find the relevant documentation for ext/hash in: > en/reference/hash/functions/ > > > [1] http://edit.php.net/
Yes, I've used the online editor in the past. But it feels weird ... and I can't even see patches I've submitted in the past. If it has to happen quickly, I'll probably use that, but I'd rather avoid it. Cheers, Andrey.

Kalle Sommer Nielsen

9 years ago
Hi Andrey 2017-01-11 21:48 GMT+01:00 Andrey Andreev <narf@devilix.net>:
> Yes, I've used the online editor in the past. But it feels weird ... and I > can't even see patches I've submitted in the past. > > If it has to happen quickly, I'll probably use that, but I'd rather avoid > it.
Yeah sadly there is some fuzz going on there if you do not have a VCS account. Although I personally prefer SVN as it is much easier and faster. You can always make a diff there and send to the docs mailing list (and it will forever be stored, and searchable from indexing sites like markmail (our own NNTP site do not support search /o\))[1] or mail it to me directly and I'll commit it in case you are not granted a VCS account. [1] http://news.php.net/group.php?group=php.doc
-- regards, Kalle Sommer Nielsen kalle@php.net

Niklas Keller

9 years ago
2017-01-11 22:06 GMT+01:00 Kalle Sommer Nielsen <kalle@php.net>:
> Hi Andrey > > 2017-01-11 21:48 GMT+01:00 Andrey Andreev <narf@devilix.net>: > > Yes, I've used the online editor in the past. But it feels weird ... and > I > > can't even see patches I've submitted in the past. > > > > If it has to happen quickly, I'll probably use that, but I'd rather avoid > > it. > > Yeah sadly there is some fuzz going on there if you do not have a VCS > account. Although I personally prefer SVN as it is much easier and > faster. You can always make a diff there and send to the docs mailing > list (and it will forever be stored, and searchable from indexing > sites like markmail (our own NNTP site do not support search /o\))[1] > or mail it to me directly and I'll commit it in case you are not > granted a VCS account.
Could we move documentation to Git and mirror it on Github, too? I think we might get more PRs on GitHub than on this strange edit.php.net editor, where probably most people edit and save, but forget to submit the actual patch. Regards, Niklas

Christoph Becker

9 years ago
CC'ing the doc list. On 11.01.2017 at 23:18, Niklas Keller wrote:
> 2017-01-11 22:06 GMT+01:00 Kalle Sommer Nielsen <kalle@php.net>: > >> Hi Andrey >> >> 2017-01-11 21:48 GMT+01:00 Andrey Andreev <narf@devilix.net>: >>> Yes, I've used the online editor in the past. But it feels weird ... and >> I >>> can't even see patches I've submitted in the past. >>> >>> If it has to happen quickly, I'll probably use that, but I'd rather avoid >>> it. >> >> Yeah sadly there is some fuzz going on there if you do not have a VCS >> account. Although I personally prefer SVN as it is much easier and >> faster. You can always make a diff there and send to the docs mailing >> list (and it will forever be stored, and searchable from indexing >> sites like markmail (our own NNTP site do not support search /o\))[1] >> or mail it to me directly and I'll commit it in case you are not >> granted a VCS account. > > Could we move documentation to Git and mirror it on Github, too? I think we > might get more PRs on GitHub than on this strange edit.php.net editor, > where probably most people edit and save, but forget to submit the actual > patch.
I also would welcome moving to Git. In my opinion the biggest problem with PhDOE is that you find a patch (whether submitted or not doesn't really matter) and sometimes you would need feedback – but you can't get it.
-- Christoph M. Becker

Kalle Sommer Nielsen

9 years ago
Hi Niklas 2017-01-11 23:18 GMT+01:00 Niklas Keller <me@kelunik.com>:
> Could we move documentation to Git and mirror it on Github, too? I think we > might get more PRs on GitHub than on this strange edit.php.net editor, where > probably most people edit and save, but forget to submit the actual patch.
Both yes and no. It is no easy or small task. The main reason we still stick to SVN is that the $Rev$ is used for keeping translation in sync with the EN version (The "magic" <!-- EN-Revision: <svn revision> --> tag, and all of our tools on doc.php.net is built around this, which means it needs a lot of work to make this change actually happen and a new and easy way (preferably in the same style as the current) for translators to easily syncing it. So far no one have started this movement, though we have talked about it, both on the phpdoc list and on IRC. I do not want to go in too much details here, to avoid hijacking the topic, but if you are interested in this project, then hit up the docs list or catch some of us on IRC (#php.doc @ EFNet)
-- regards, Kalle Sommer Nielsen kalle@php.net

Joe Watkins

9 years ago
Morning Andrey, Please request a VCS account, put my name in it, and holla at me with username. Cheers Joe On Wed, Jan 11, 2017 at 11:04 PM, Kalle Sommer Nielsen <kalle@php.net> wrote: