Everything

php

Small mistake on wiki

php.internals

Unnamed Person

9 years ago

Hi,

The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data
says:

> zend_execute_data.num_args - number of arguments passed to the function (this is a new field)

However, there's no such field in zend_execute_data structure:
https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414

Probably this line should be removed from the wiki page.

Thanks

Kalle Sommer Nielsen

9 years ago

Hi

2017-01-12 9:38 GMT+01:00  <sachavav@tut.by>:

> Hi,
>
> The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data
> says:
>
>> zend_execute_data.num_args - number of arguments passed to the function (this is a new field)
>
> However, there's no such field in zend_execute_data structure:
> https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
> it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414
>
> Probably this line should be removed from the wiki page.

True, but PHP 5 is still widely available and 5.6 is still supported.
Some companies support their extensions for PHP even longer than we
support that specific branch, so leaving such information, despite we
have only a tiny bit internals docs laying around may not be such a
bad idea.

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Joe Watkins

9 years ago

Morning,

Other stuff that has been removed has strike through it, that would seem
approrpiate ?

Cheers
Joe

On Thu, Jan 12, 2017 at 8:59 AM, Kalle Sommer Nielsen <kalle@php.net> wrote:

Kalle Sommer Nielsen

9 years ago

2017-01-12 10:28 GMT+01:00 Joe Watkins <pthreads@pthreads.org>:

> Morning,
>
> Other stuff that has been removed has strike through it, that would seem
> approrpiate ?

Seems like a good idea, then we can indicate its not suggested to use
anymore and we still keep the information readable :)

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Unnamed Person

9 years ago

12.01.2017, 11:59, "Kalle Sommer Nielsen" <kalle@php.net>:

> Hi
>
> 2017-01-12 9:38 GMT+01:00 <sachavav@tut.by>:
>>  Hi,
>>
>>  The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data
>>  says:
>>
>>>  zend_execute_data.num_args - number of arguments passed to the function (this is a new field)
>>
>>  However, there's no such field in zend_execute_data structure:
>>  https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430
>>  it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414
>>
>>  Probably this line should be removed from the wiki page.
>
> True, but PHP 5 is still widely available and 5.6 is still supported.
> Some companies support their extensions for PHP even longer than we
> support that specific branch, so leaving such information, despite we
> have only a tiny bit internals docs laying around may not be such a
> bad idea.

This wiki page is specifically for PHP 7 migration, it has nothing to do with PHP5