Everything

php

Patch for bug #65312: Segmentation fault with filesize=4096

php.internals

Richard H Lee

9 years ago

I submitted a patch for bug #65312 "Segmentation fault with
filesize=4096". It's to do with the way Cygwin handles mmap()ing. It is
not a duplicate of another bug as marked, it is specific to Cygwin.

I'm not sure about the release structure of PHP, but it would be great
if I could get this patch into the 7.0, 7.1 and master branches. I was
hoping to get in in for 7.0.19, but it looks as if I have just missed it.


Richard

Richard H Lee

9 years ago

Hi Anatol,

I noticed you were quite involved with bug #65312 "Segmentation fault
with=filesize=4096" and possibly may have a better idea of what is going
on with it.

Could you take a look at the patch please? It's basically two identical
3 line additions (#if, #define and #endif) that change the page size to
4096 if the OS is Cygwin. It would be nice to get this patch into 7.0,
7.1 and master.


Richard

Anatol Belski

9 years ago

Hi,

> -----Original Message-----
> From: Richard H Lee [mailto:ricardohenrylee@gmail.com]
> Sent: Thursday, May 11, 2017 3:18 PM
> To: internals@lists.php.net
> Subject: [PHP-DEV] Patch for bug #65312: Segmentation fault with filesize=4096
>
> I submitted a patch for bug #65312 "Segmentation fault with filesize=4096". It's
> to do with the way Cygwin handles mmap()ing. It is not a duplicate of another
> bug as marked, it is specific to Cygwin.
>
> I'm not sure about the release structure of PHP, but it would be great if I could
> get this patch into the 7.0, 7.1 and master branches. I was hoping to get in in for
> 7.0.19, but it looks as if I have just missed it.
>

Thanks for forwarding this. In first place - why using Cygwin if there's a native build? OFC we might apply the patch if it fixed some bug, where I think usage of Cygwin is an issue in first place, for performance and portability reasons at least. Especially as I won't be able to test the patch because Cygwin breaks the dev environments and requires to reinstall the whole system to fix that, at least proven for me many times after which I gave up and started to actively disregard Cygwin. Are there yet other users to confirm the issue/fix?

Thanks

Anatol