Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [RFC] Allow loading extensions by name »

[RFC] Allow loading extensions by name

php.internals

Unnamed Person

9 years ago
Hi, Feature was discussed last year. I am now opening the vote for a merge in 7.2. URL: https://wiki.php.net/rfc/load-ext-by-name Voting period ends Monday, June 19, 2017, 00:00 UTC. Regards François

Unnamed Person

9 years ago
Sorry, forgot [VOTE] in subject... Le 01/06/2017 à 14:46, François Laupretre a écrit :

François Laupretre

9 years ago
Hi, RFC was appoved (17 to 4). Thanks to all who took the time to discuss and vote about this. I just rebased the PR to the current master. Could someone with appropriate rights merge it ? Thanks. Regards François Le 01/06/2017 à 17:18, François Laupretre a écrit :

Sara Golemon

9 years ago
On Mon, Jun 19, 2017 at 1:09 PM, François Laupretre <francois@tekwire.net> wrote:
> RFC was appoved (17 to 4). Thanks to all who took the time to discuss and > vote about this. > > I just rebased the PR to the current master. Could someone with appropriate > rights merge it ? Thanks. >
I was about to merge this, but ran into some issues (mostly minor). Could you at least address the fwrite(stderr, ...) item (and preferably clean up the style nits while you're at it)? Oh, and I forgot to include it in the CR, but there are some tabs/spaces issues as well. -Sara

François Laupretre

9 years ago
Hi Sara, Le 19/06/2017 à 23:33, Sara Golemon a écrit :
> I was about to merge this, but ran into some issues (mostly minor). > Could you at least address the fwrite(stderr, ...) item (and > preferably clean up the style nits while you're at it)? > > Oh, and I forgot to include it in the CR, but there are some > tabs/spaces issues as well.
I fixed typos and style issues. About the 'fwrite(stderr,', I just used the same mechanism used by zend_load_extension() to raise an error. If you consider it is safe to replace it with a call to zend_error(), I'll do it. Regards François

Sara Golemon

9 years ago
I'll double check later today, it might be that this comes in from the startup phase and we can't do zend_error() for some reason. Either way I'll get it merged soonish. Thanks. -Sara On Tue, Jun 20, 2017 at 6:53 AM, François Laupretre <francois@tekwire.net> wrote: