libsodium version target for 7.2

php.internals

David Zuelke

9 years ago
Hi all, The standalone sodium extension has been changed a few days ago to require libsodium 1.0.9: https://github.com/jedisct1/libsodium-php/commit/e4d6d281cf197deb0086b592a72f282905ba7ead Will this version requirement also be ported to the PHP-7.2 branch? The reason I'm asking is because the current Ubuntu LTS (16.04) has version 1.0.8 of libsodium, and IMO that's an important platform to take into consideration. The next LTS (18.04) isn't due until mid 2018. Cheers, David

Sara Golemon

9 years ago
On Thu, Jul 20, 2017 at 7:16 PM, David Zuelke <dz@heroku.com> wrote:
> The standalone sodium extension has been changed a few days ago to require libsodium 1.0.9: https://github.com/jedisct1/libsodium-php/commit/e4d6d281cf197deb0086b592a72f282905ba7ead > > Will this version requirement also be ported to the PHP-7.2 branch? >
I'm going to guess "No" since all of Frank's commits since the branch have gone to master only so he must not be targeting 7.2 with any of these changes.
> The reason I'm asking is because the current Ubuntu LTS (16.04) has version > 1.0.8 of libsodium, and IMO that's an important platform to take into consideration. > The next LTS (18.04) isn't due until mid 2018. >
Agreed. Current Ubuntu LTS is a pretty reasonable minimum. I'm all for taking advantage of newer lib features, but we should have enough #ifdefs to avoid breaking reasonably old libs. -Sara