Everything

php

Expose gmp_ce and friends

php.internals

Sara Golemon

8 years ago

Stas specifically, but also others:

Any objections if I apply
https://github.com/php/php-src/compare/master...sgolemon:gmp.export to
make consuming GMP objects from third-party extensions easier?

-Sara

Kalle Sommer Nielsen

8 years ago

Hi Sara

2017-10-02 23:33 GMT+02:00 Sara Golemon <pollita@php.net>:

> Stas specifically, but also others:
>
> Any objections if I apply
> https://github.com/php/php-src/compare/master...sgolemon:gmp.export to
> make consuming GMP objects from third-party extensions easier?

+1, only note I have is that with the change to config.m4, a relevant
one should maybe also follow for phpize on Windows for config.w32

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Johannes Schlueter

8 years ago

On Mo, 2017-10-02 at 17:33 -0400, Sara Golemon wrote:

> Stas specifically, but also others:
>
> Any objections if I apply
> https://github.com/php/php-src/compare/master...sgolemon:gmp.export
> to
> make consuming GMP objects from third-party extensions easier?
>
> -Sara

I would prefer not exporting the php_gmp.h, but a gmp.h (or similar)
and let php_gmp.h there for main/builtin_functions.c only. If a
consumer wants access to the module_entry they can query EG(modules)
and other declarations in there should be "private".

johannes

Sara Golemon

8 years ago

On Thu, Oct 5, 2017 at 8:50 AM, Johannes Schlüter
<johannes@schlueters.de> wrote:

> I would prefer not exporting the php_gmp.h, but a gmp.h (or similar)
> and let php_gmp.h there for main/builtin_functions.c only. If a
> consumer wants access to the module_entry they can query EG(modules)
> and other declarations in there should be "private".
>

Yeah, I shouldn't be lazy. I should do things right.

On Wed, Oct 4, 2017 at 5:32 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:

> +1, only note I have is that with the change to config.m4, a relevant
> one should maybe also follow for phpize on Windows for config.w32
>

Ugh, windows... is that still a thing?