Everything

php

php wiki user, want to contribute edits

php.internals

Craig Comstock

8 years ago

Hi,

I was upgrading php5 to php7 and managing some C extension code. Noticed a small typo in https://wiki.php.net/phpng-int and wanted to contribute where I could since I'll likely be supporting our use of PHP and extensions for a while.

%s/world/word/

is the very small change I found so far on that page.

Cheers,
Craig Comstock
Engineer at Northern.tech

Kalle Sommer Nielsen

8 years ago

Hi Craig

2018-01-09 16:13 GMT+01:00 Craig Comstock <craig@unreasonablefarm.org>:

> Hi,
>
> I was upgrading php5 to php7 and managing some C extension code. Noticed a small typo in https://wiki.php.net/phpng-int and wanted to contribute where I could since I'll likely be supporting our use of PHP and extensions for a while.
>
> %s/world/word/
>
> is the very small change I found so far on that page.

Thanks, fixed!

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Craig Comstock

8 years ago

> Thanks, fixed!

A few more little changes:

%s/Global symbol tales/Global symbol tables/
%s/operands jut refer/operands just refer/

Thanks for the docs. I'm off to read https://wiki.php.net/phpng-upgrading as I got segfaults in my
php extension when upgrading from 5 to 7 due to zend_parse_parameters() change from int to size_t
on string length parameters. :)

Cheers,
Craig

Niklas Keller

8 years ago

>
> > Thanks, fixed!
> A few more little changes:
>
> %s/Global symbol tales/Global symbol tables/
> %s/operands jut refer/operands just refer/
>
> Thanks for the docs. I'm off to read https://wiki.php.net/phpng-upgrading
> as I got segfaults in my
> php extension when upgrading from 5 to 7 due to zend_parse_parameters()
> change from int to size_t
> on string length parameters. :)
>
> Cheers,
> Craig

Thanks, fixed.