Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » DateTime::__set_state() argument changing? »

DateTime::__set_state() argument changing?

php.internals

Antonio Carlos Ribeiro

8 years ago
Due to a recent change in the Carbon PHP library, I'm now getting this error, only when testing on PHP Nightly: *Declaration of Carbon\Carbon::__set_state(array $state) should be compatible with DateTime::__set_state($array)* Is the argument type hinting being removed on PHP 7.3? You can see them all passing on Travis, except for Nightly: https://travis-ci.org/antonioribeiro/ia-collection Antonio Carlos Ribeiro acr@antoniocarlosribeiro.com (+55) 21-9-8088-2233 (celular TIM) (+55) 21-2556-3164 (fixo residencial) skype: antoniocarlosribeiro _______________ *I must say I find television very educational. The minute somebody turns it on, I go to the library and read a good book.** (* *Devo dizer que acho televisão muito educativo. Quando alguém a liga, vou à biblioteca e leio um bom livro.) (Groucho Marx)*

Gabriel Caruso

8 years ago
Hello Antonio. Please see https://github.com/php/php-src/pull/3038 for more information. Also, use the https://bugs.php.net if you judge this is a bug. Thanks Em sex, 9 de mar de 2018 às 13:15, Antonio Carlos Ribeiro < acr@antoniocarlosribeiro.com> escreveu:
> Due to a recent change in the Carbon PHP library, I'm now getting this > error, only when testing on PHP Nightly: > > > *Declaration of Carbon\Carbon::__set_state(array $state) should be > compatible with DateTime::__set_state($array)* > > Is the argument type hinting being removed on PHP 7.3? > > You can see them all passing on Travis, except for Nightly: > > https://travis-ci.org/antonioribeiro/ia-collection > > Antonio Carlos Ribeiro > acr@antoniocarlosribeiro.com > > (+55) 21-9-8088-2233 (celular TIM) > (+55) 21-2556-3164 <+55%2021%202556-3164> (fixo residencial) > > skype: antoniocarlosribeiro > > _______________ > > *I must say I find television very educational. The minute somebody turns > it on, I go to the library and read a good book.** (* > > *Devo dizer que acho televisão muito educativo. Quando alguém a liga, vou à > biblioteca e leio um bom livro.) (Groucho Marx)* >
-- Gabriel Caruso

Antonio Carlos Ribeiro

8 years ago
I get it now, Gabriel, thanks for the clarification. Cheers! Antonio Carlos Ribeiro acr@antoniocarlosribeiro.com (+55) 21-9-8088-2233 (celular TIM) (+55) 21-2556-3164 (fixo residencial) skype: antoniocarlosribeiro _______________ *I must say I find television very educational. The minute somebody turns it on, I go to the library and read a good book.** (* *Devo dizer que acho televisão muito educativo. Quando alguém a liga, vou à biblioteca e leio um bom livro.) (Groucho Marx)* On Fri, Mar 9, 2018 at 1:31 PM, Gabriel Caruso <carusogabriel34@gmail.com> wrote: