Everything

php

PHP 7.3 branched

php.internals

Christoph Becker

8 years ago

That's it! Feature freeze is on.

Please include branch PHP-7.3 in all merges from 7.1 and earlier.
Please commit all 7.3 fixes to PHP-7.3 and merge to master which is
now targetting 7.4.

This is real.  <http://git.php.net/?p=php-src.git;a=commit;h=a63c99b>.

--
Christoph M. Becker

Derick Rethans

8 years ago

On Tue, 31 Jul 2018, Christoph M. Becker wrote:

> That's it! Feature freeze is on.
>
> Please include branch PHP-7.3 in all merges from 7.1 and earlier.
> Please commit all 7.3 fixes to PHP-7.3 and merge to master which is
> now targetting 7.4.
>
> This is real.  <http://git.php.net/?p=php-src.git;a=commit;h=a63c99b>.

I've just compiled this from source, and I get the following upon "make
install":

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in
phar:///home/derick/dev/php/php-src.git/pear/install-pear-nozlib.phar/PEAR/PackageFile/v2/Validator.php on line 1933

It looks like we need to update the PEAR phar.

cheers,
Derick

--
https://derickrethans.nl | https://xdebug.org | https://dram.io
Like Xdebug? Consider a donation: https://xdebug.org/donate.php,
or become my Patron: https://www.patreon.com/derickr
twitter: @derickr and @xdebug

Christoph Becker

8 years ago

On 31.07.2018 at 14:55, Derick Rethans wrote:

> On Tue, 31 Jul 2018, Christoph M. Becker wrote:
>
>> This is real.  <http://git.php.net/?p=php-src.git;a=commit;h=a63c99b>.
>
> I've just compiled this from source, and I get the following upon "make
> install":
>
> Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in
> phar:///home/derick/dev/php/php-src.git/pear/install-pear-nozlib.phar/PEAR/PackageFile/v2/Validator.php on line 1933
>
> It looks like we need to update the PEAR phar.

It's already been fixed in the repo[1], but someone would have to roll
out a new release.

[1] <https://github.com/pear/pear-core/commit/04b4624>

--
Christoph M. Becker

Kalle Sommer Nielsen

8 years ago

Den tir. 31. jul. 2018 kl. 17.58 skrev Christoph M. Becker <cmbecker69@gmx.de>:

> [1] <https://github.com/pear/pear-core/commit/04b4624>

Off-topic: Perhaps its time to look at alternatives and unbundle pear
instead of only seeimly (at a quick glance) keeping it alive for newer
PHP compatibility, which seems to have the main case for the last
couple of years. We had issues with pear releases at close to every
larger release in close to 10 years.

We have alternatives like pickle[1] thats fairly new or I'm sure we
can develop a tool capable of managing PECL extensions.

[1] https://github.com/FriendsOfPHP/pickle

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Christoph Becker

8 years ago

On 31.07.2018 at 18:44, Kalle Sommer Nielsen wrote:

> Off-topic: Perhaps its time to look at alternatives and unbundle pear
> instead of only seeimly (at a quick glance) keeping it alive for newer
> PHP compatibility, which seems to have the main case for the last
> couple of years. We had issues with pear releases at close to every
> larger release in close to 10 years.

Hardly surprising.  I've recently seen some current PEAR code
(trunk/master), and this was still written with PHP 4 compatibility in
mind (lots of reference assignments for objects, for instance).

> We have alternatives like pickle[1] thats fairly new or I'm sure we
> can develop a tool capable of managing PECL extensions.
>
> [1] https://github.com/FriendsOfPHP/pickle

I've never tried pickle, and I have no idea about its status and
usability (after all, further development appears to have been mostly
ceased[2]), but still it might be the best way to move forward.

[2] <https://github.com/FriendsOfPHP/pickle/graphs/contributors>

--
Christoph M. Becker

Kalle Sommer Nielsen

8 years ago

Den tir. 31. jul. 2018 kl. 22.57 skrev Christoph M. Becker <cmbecker69@gmx.de>:

> I've never tried pickle, and I have no idea about its status and
> usability (after all, further development appears to have been mostly
> ceased[2]), but still it might be the best way to move forward.
>
> [2] <https://github.com/FriendsOfPHP/pickle/graphs/contributors>

I noticed that when glancing over it before I sent my mail. Either way
I think this is something we should have a look at, or at least invest
the time into something so we can ease our pain for releases. Not that
I have anything in mind for PEAR in paticular, but it seems odd for us
to still rely on something that seems essentially dead.

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Gabriel Caruso

8 years ago

>
> That's it! Feature freeze is on.
>
> Please include branch PHP-7.3 in all merges from 7.1 and earlier.
> Please commit all 7.3 fixes to PHP-7.3 and merge to master which is
> now targetting 7.4.
>
> This is real.  <http://git.php.net/?p=php-src.git;a=commit;h=a63c99b>.
>
> --
> Christoph M. Becker

Should we also update the README.GIT-RULES[1] file, or wait for the
official release before it?

[1]:
http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES;h=1a0c1aebaeeeee7d27747cc9f8f0d9c4c36c62f7;hb=refs/heads/master#l47

--
Gabriel Caruso

Christoph Becker

8 years ago

On 31.07.2018 at 15:09, Gabriel Caruso wrote:

> Should we also update the README.GIT-RULES[1] file, or wait for the
> official release before it?
>
> [1]:
> http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES;h=1a0c1aebaeeeee7d27747cc9f8f0d9c4c36c62f7;hb=refs/heads/master#l47

Good catch, Gabriel!  I'll update the file (and add a respective note to
README.RELEASE_PROCESS) later, if nobody beats me to it.

--
Christoph M. Becker

Nikita Popov

8 years ago

On Tue, Jul 31, 2018 at 3:13 PM, Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 31.07.2018 at 15:09, Gabriel Caruso wrote:
>
> > Should we also update the README.GIT-RULES[1] file, or wait for the
> > official release before it?
> >
> > [1]:
> > http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES;h=
> 1a0c1aebaeeeee7d27747cc9f8f0d9c4c36c62f7;hb=refs/heads/master#l47
>
> Good catch, Gabriel!  I'll update the file (and add a respective note to
> README.RELEASE_PROCESS) later, if nobody beats me to it.
>

Would probably be a good time to empty UPGRADING and UPGRADING.INTERNALS as
well.

Nikita

Christoph Becker

8 years ago

On 31.07.2018 at 15:18, Nikita Popov wrote:

> On Tue, Jul 31, 2018 at 3:13 PM, Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
>
>> On 31.07.2018 at 15:09, Gabriel Caruso wrote:
>>
>>> Should we also update the README.GIT-RULES[1] file, or wait for the
>>> official release before it?
>>>
>>> [1]:
>>> http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES;h=
>> 1a0c1aebaeeeee7d27747cc9f8f0d9c4c36c62f7;hb=refs/heads/master#l47
>>
>> Good catch, Gabriel!  I'll update the file (and add a respective note to
>> README.RELEASE_PROCESS) later, if nobody beats me to it.
>>
>
> Would probably be a good time to empty UPGRADING and UPGRADING.INTERNALS as
> well.

Thanks!  I've did that right away
(<http://git.php.net/?p=php-src.git;a=commit;h=bccf0df>).

--
Christoph M. Becker

Christoph Becker

8 years ago

On 31.07.2018 at 15:13, Christoph M. Becker wrote:

> On 31.07.2018 at 15:09, Gabriel Caruso wrote:
>
>> Should we also update the README.GIT-RULES[1] file, or wait for the
>> official release before it?
>>
>> [1]:
>> http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES;h=1a0c1aebaeeeee7d27747cc9f8f0d9c4c36c62f7;hb=refs/heads/master#l47
>
> Good catch, Gabriel!  I'll update the file (and add a respective note to
> README.RELEASE_PROCESS) later, if nobody beats me to it.

Done: <http://git.php.net/?p=php-src.git;a=commit;h=7866f28>.

--
Christoph M. Becker

Gabriel Caruso

8 years ago

>
> That's it! Feature freeze is on.
>
> Please include branch PHP-7.3 in all merges from 7.1 and earlier.
> Please commit all 7.3 fixes to PHP-7.3 and merge to master which is
> now targetting 7.4.
>
> This is real.  <http://git.php.net/?p=php-src.git;a=commit;h=a63c99b>.
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

Should we also "branch" PHP 7.3 in GCOV (http://gcov.php.net/)?

--
Gabriel Caruso

Christoph Becker

8 years ago

On 01.08.2018 at 18:38, Gabriel Caruso wrote:

> Should we also "branch" PHP 7.3 in GCOV (http://gcov.php.net/)?

I've already sent a mail to Nuno yesterday, as suggested in
README.RELEASE_PROCESS[1], but didn't receive any reply yet.  It doesn't
hurry, anyway. :)

[1]
<https://github.com/php/php-src/blob/7866f28/README.RELEASE_PROCESS#L354>

--
Christoph M. Becker