Everything

php

RFC Proposal: Make the hash extension always available

php.internals

Kalle Sommer Nielsen

8 years ago

Gday fellow hackers

I just posted an RFC and set it up for discussion[1], this proposes to
make the ext/hash extension always enabled, similar to that for date,
spl & pcre.

Comments are welcome. I intend to start voting in 2-3 weeks time,
should there be no critical issues in regards to this RFC.


[1] https://wiki.php.net/rfc/permanent_hash_ext

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Christoph Becker

8 years ago

On 04.09.2018 at 11:11, Kalle Sommer Nielsen wrote:

> I just posted an RFC and set it up for discussion[1], this proposes to
> make the ext/hash extension always enabled, similar to that for date,
> spl & pcre.
>
> Comments are welcome. I intend to start voting in 2-3 weeks time,
> should there be no critical issues in regards to this RFC.
>
>
> [1] https://wiki.php.net/rfc/permanent_hash_ext

That appears to be sensible.  Anyhow, *if* we do this, we also should
move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and
SHA1 is currently dead code in ext/hash, and the CRC32 implementation
seems to be duplicated).  We should also have a look at crypt_sha256.c
and crypt_sha512.c (of ext/standard) which likely duplicate some code
already available in ext/hash.

--
Christoph M. Becker

Kalle Sommer Nielsen

8 years ago

Den tir. 4. sep. 2018 kl. 12.20 skrev Christoph M. Becker <cmbecker69@gmx.de>:

> That appears to be sensible.  Anyhow, *if* we do this, we also should
> move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and
> SHA1 is currently dead code in ext/hash, and the CRC32 implementation
> seems to be duplicated).  We should also have a look at crypt_sha256.c
> and crypt_sha512.c (of ext/standard) which likely duplicate some code
> already available in ext/hash.

Those makes a lot of sense to do, and definitely something we should
if this RFC passes

--
regards,

Kalle Sommer Nielsen
kalle@php.net

Sara Golemon

8 years ago

On Tue, Sep 4, 2018 at 4:11 AM, Kalle Sommer Nielsen <kalle@php.net> wrote:

> I just posted an RFC and set it up for discussion[1], this proposes to
> make the ext/hash extension always enabled, similar to that for date,
> spl & pcre.
>
> Comments are welcome. I intend to start voting in 2-3 weeks time,
> should there be no critical issues in regards to this RFC.
>

As ext/hash's original author, I always dreamed this day would come.