PHAR maintainer?

php.internals

Stas Malyshev

7 years ago
Hi! PHAR is pretty widely used component of PHP ecosystem, as I understand, but all people listed as maintainers for the extension haven't been active in the project for a decade. Is there somebody still willing to take care of it? I've been fixing a variety of security issues there, but I don't really understand a lot of things there (especially how caching works there) and frankly don't have enough spare time to do a deep dive there to figure it out. And we have embarrassing bugs like https://bugs.php.net/bug.php?id=77432 that need to be fixed. So is somebody willing to step up there? Thanks,
-- Stas Malyshev smalyshev@gmail.com

Bishop Bettini

7 years ago
On Sun, Jan 20, 2019 at 9:01 PM Stanislav Malyshev <smalyshev@gmail.com> wrote:
> Hi! > > PHAR is pretty widely used component of PHP ecosystem, as I understand, > but all people listed as maintainers for the extension haven't been > active in the project for a decade. Is there somebody still willing to > take care of it? >
I've been fixing phar bugs here and there over the last year, and I'm happy to take on a more diligent process to maintain ext/phar officially. Do we have, anywhere, a maintainers guide that talks about the maintainers' responsibilities? bishop

Stas Malyshev

7 years ago
Hi!
> I've been fixing phar bugs here and there over the last year, and I'm > happy to take on a more diligent process to maintain ext/phar officially. > > Do we have, anywhere, a maintainers guide that talks about the > maintainers' responsibilities?
First of all, thanks for volunteering! There's no real formal guide, but basically maintainer should monitor the tickets filed against the extensions and provide fixes for them. There seems to be a bunch of open ones: https://bugs.php.net/search.php?search_for=&boolean=0&limit=30&order_by=&direction=DESC&cmd=display&status=Open&bug_type=All&project=All&package_name%5B%5D=PHAR+related so making a pass over them, seeing which ones still exist and confirming them, closing those that don't happen anymore and starting fixing those that still happen would be a good start. If you need somebody to review, I'd be glad to help with whatever I can. Thanks,
-- Stas Malyshev smalyshev@gmail.com

Bishop Bettini

7 years ago
On Thu, Jan 31, 2019 at 3:13 PM Stanislav Malyshev <smalyshev@gmail.com> wrote:
> Hi! > > > I've been fixing phar bugs here and there over the last year, and I'm > > happy to take on a more diligent process to maintain ext/phar officially. > > > > Do we have, anywhere, a maintainers guide that talks about the > > maintainers' responsibilities? > > First of all, thanks for volunteering!
There's no real formal guide, but basically maintainer should monitor
> the tickets filed against the extensions and provide fixes for them.
There seems to be a bunch of open ones:
> > https://bugs.php.net/search.php?search_for=&boolean=0&limit=30&order_by=&direction=DESC&cmd=display&status=Open&bug_type=All&project=All&package_name%5B%5D=PHAR+related > > so making a pass over them, seeing which ones still exist and confirming > them, closing those that don't happen anymore and starting fixing those > that still happen would be a good start. If you need somebody to review, > I'd be glad to help with whatever I can. >
Excellent, that's exactly what I had started to do, before pausing to welcome my son into the world. Being back at it, I've set a goal to triage one bug a week, which positions us to be potentially phar bug free in about a year. (Assuming the ingress rate of about 6/year remains stable.) Some I've triaged quite a while ago, and I felt a more comprehensive refactor would be appropriate. I'll leave those alone until I have more total experience with the code and focus my first efforts on the low hanging fruit. Do I need to request any special git access or just keep doing the usual PR process? bishop

Stas Malyshev

7 years ago
Hi!
> Do I need to request any special git access or just keep doing the usual > PR process?
For now, just keep the PRs - ping me and/or this list if they linger too long without review. Eventually I assume we'd just setup you access to ext/phar but PRs seem to be good way for now to start without delay.
-- Stas Malyshev smalyshev@gmail.com