Everything

php

Drop support for libreadline

php.internals

Remi Collet

7 years ago

Hi,

Terribly old and known issue.

libreadline license (GPL) is incompatible with PHP

We support build with libedit (BSD) for years

Most Linux distribution use libedit
Windows also use libedit

So, this PR is mostly a cleanup of what should have been removed for years.

Feedback before merge ?

Remi

Christoph Becker

7 years ago

On 13.02.2019 at 11:56, Remi Collet wrote:

> Terribly old and known issue.
>
> libreadline license (GPL) is incompatible with PHP
>
> We support build with libedit (BSD) for years
>
> Most Linux distribution use libedit
> Windows also use libedit
>
>
> So, this PR is mostly a cleanup of what should have been removed for years.
>
>
> Feedback before merge ?

I'm fine with dropping libreadline support, but it should be pointed out
that readline_list_history() doesn't work with libedit, and would be
completely removed.

--
Christoph M. Becker

Remi Collet

7 years ago

Le 13/02/2019 à 12:51, Christoph M. Becker a écrit :

> It should be pointed out
> that readline_list_history() doesn't work with libedit, and would be
> completely removed.

This function is available in recent libedit version (3.1+)
So I'm working on a patch to enable it (can also be later added in 7.2+)

Remi

Johannes Schlueter

7 years ago

Hi,

On Mi, 2019-02-13 at 11:56 +0100, Remi Collet wrote:

> Hi,
>
>
> Terribly old and known issue.
>
> libreadline license (GPL) is incompatible with PHP
>
> We support build with libedit (BSD) for years
>
> Most Linux distribution use libedit
> Windows also use libedit
>
>
> So, this PR is mostly a cleanup of what should have been removed for
> years.
>

I don't know the size of the patch for this, but as long as we are not
using readline-specific APIs isn't it the user's choice/responsibility
if they happen to link to readline? - As long as that isn't
distributed, but only for their own use it's fine. GPL limits
"redistribution" not "usage"

It is a while since I used libedit last, but in behavior it had notable
differences.

johannes

Remi Collet

7 years ago

Missing links

PHP 8.0 => https://github.com/php/php-src/pull/3823
Drop support for libreadline

PHP 7.x => https://github.com/php/php-src/pull/3824
add readline_list_history with libedit >= 3.1


Remi