[RFC] [VOTE] JIT

Such complex and far reaching features should clearly have a two week voting period, please update the RFC. Cheers Joe On Thu, 21 Mar 2019 at 12:58, Dmitry Stogov <dmitry@zend.com> wrote:

Hi, The vote seems currently closed, but as long as it says: Proposed PHP version: PHP 7.4 I won't be voting for it. This should squarely just be targetted at PHP 8.0. cheers, Derick On Thu, 21 Mar 2019, Dmitry Stogov wrote:

On Thu, Mar 21, 2019 at 12:58 PM Dmitry Stogov <dmitry@zend.com> wrote:

Thanks a lot for your work on this Dmitry! I didn't expect to see full Windows & ZTS support so soon :) A few people have already commented on the question of 7.4 vs 8.0, here are my thoughts on that. Pros: * If Linux distros build with the JIT compiled in, we may get much more testing, as not many people compile PHP themselves. * It allows testing the JIT on code that is not compatible with PHP 8.0, but is compatible with PHP 7.4. Cons: * The JIT for PHP 8 will (presumably) see a lot more work to improve performance, in particular based on runtime profiling and speculative optimization. This means that tests run with the PHP 7.4 JIT may not be representative (and may show worse than actual performance). * It makes for better marketing to include it in PHP 8. PHP 7.4 is already a very packed release (FFI, preloading, typed properties, type covariance, ??=, maybe short closures), probably the most important release since 7.0. * More maintenance burden: I think you are right that we won't be seeing many major changes land in 7.4 anymore. But with the number of other big features already in 7.4, I think we have enough new bug surface area to deal with already. (Unfortunately we are still not on top of all stability issues from PHP 7.3...) Overall, I think overall we're better served with introducing the JIT in PHP 8.0. Nikita

Hello, On Thu, 21 Mar 2019 at 12:58, Dmitry Stogov <dmitry@zend.com> wrote:

+1 to both options. Having such feature in the PHP-7.4 is also good to be able to check it out sooner (and to have some test base). With having this in PHP 8.0 we will need to wait for more than a year to check it out. I'm sure very little people will compile PHP 8.0-dev on their own and install it to test that before the release. PHP 8.0.0 release could be also about removing deprecated functionality. This approach is actually following semver https://semver.org, so that's all good I think. In any case if we will need to wait more than another year or not, thank you for your great work. Thumbs up. :)