[RFC] Allow trailing comma in parameter lists

On Thu, Mar 26, 2020 at 7:52 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

This would be a great addition, my "duplicate line" thanks you! (and so I) Regards, Lynn

On Thu, Mar 26, 2020, at 1:52 PM, Nikita Popov wrote:

Endorse. I don't think there's anything more to add, just "endorse". --Larry Garfield

Yes, please Cheers, Ben

Hi internals, I'd just like to add that https://wiki.php.net/rfc/trailing_comma_in_parameter_list seems useful, especially now that PSR-12 is approved and https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments recommends that "When the argument list is split across multiple lines, the closing parenthesis and opening brace MUST be placed together on their own line with one space between them." (Previously, I don't think there was any attempt at standardizing a recommendation of where the closing parenthesis should go) ``` class ClassName { public function aVeryLongMethodName( ClassTypeHint $arg1, &$arg2, array $arg3 = [] // comma would be useful here when adding or removing in diffs ) { // method body } } ``` - Tyson

I have no idea why we failed to approve trailing comma over lists in general, but this seems to be a step forward. My `git diff` says +1 Thanks, Márcio

On 26/03/2020 18:52, Nikita Popov wrote:

Hi Nikita, While I'd personally be fine with this change, I think we should understand why the previous proposal failed rather than just hoping the vote goes differently this time. Specifically, this vote was only 3 years ago, and although it achieved a majority, was well short of the 2/3 requirement: https://wiki.php.net/rfc/list-syntax-trailing-commas#functionmethod_arguments_declarations_calls Notably, a followup RFC proposing only function *calls* allow trailing commas, passed a few months later, and includes this specific rationale: https://wiki.php.net/rfc/trailing-comma-function-calls#wait_didn_t_we_just_vote_on_this

“yes” for function calls, but “no” for function declarations. ThisRFC proposes allowing a trailing comma in function call syntax only. Looking back at the discussions from 2017, I can see a couple of people taking that position, but not expanding on it. Does anyone still hold that view, and want to explain why they feel that way? Side-note - here's a quick timeline of related RFCs: - Feb 2013: https://wiki.php.net/rfc/trailing-comma-function-args - function calls only, rejected 15:20 - Oct 2015: https://wiki.php.net/rfc/revisit-trailing-comma-function-args - withdrawn in favour of next RFC - Nov 2015, voted Jan 2017: https://wiki.php.net/rfc/list-syntax-trailing-commas - function calls and parameters, rejected 24:20 - Oct 2017: https://wiki.php.net/rfc/trailing-comma-function-calls - function calls only, passed 30:10 - Mar 2020: https://wiki.php.net/rfc/trailing_comma_in_parameter_list - function parameters only... Regards,

On Thu, Mar 26, 2020 at 7:52 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

Heads up: I plan to move this to voting tomorrow. Don't think there's much to discuss here... Nikita