PHP 8.0 branch cut

php.internals

Sara Golemon

5 years ago
Next Tuesday, Sep 15th, has been marked on my calendar as the branch date for PHP-8.0 which would open master up for 8.1 targeted work. This would mean that bug fixes would need to include PHP-8.0 in their merge chain (meaning more work to merge 8.0 targeted fixes). Please let Gabriel and I know how you feel about this date. I can see that master is still quite active, and I don't wish to make the work to stablize the 8.0 release any more difficult than it has to be. -Sara

Nikita Popov

5 years ago
On Fri, Sep 11, 2020 at 6:49 PM Sara Golemon <pollita@php.net> wrote:
> Next Tuesday, Sep 15th, has been marked on my calendar as the branch date > for PHP-8.0 which would open master up for 8.1 targeted work. > > This would mean that bug fixes would need to include PHP-8.0 in their merge > chain (meaning more work to merge 8.0 targeted fixes). > > Please let Gabriel and I know how you feel about this date. I can see that > master is still quite active, and I don't wish to make the work to stablize > the 8.0 release any more difficult than it has to be. > > -Sara >
Hey Sara, I think it would be good to make this week's release beta4 rather than rc1 (without affecting the rest of the schedule). In that case we'd also push back the branching and final ABI freeze two weeks. We're close to done with the warning to Error exception promotion task, but haven't really started on reviewing and consolidating parameter names yet (in preparation for named parameters). It would be good to have that work mostly finalized before RC1, so we can limit the number of nominally BC-breaking changes past RC1 (I expect we'll still fix some things that slipped through the cracks, but at least we should prevent any mass changes). Regards, Nikita

Sara Golemon

5 years ago
On Mon, Sep 14, 2020 at 9:39 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Fri, Sep 11, 2020 at 6:49 PM Sara Golemon <pollita@php.net> wrote: > >> Next Tuesday, Sep 15th, has been marked on my calendar as the branch date >> for PHP-8.0 which would open master up for 8.1 targeted work. >> >> This would mean that bug fixes would need to include PHP-8.0 in their >> merge >> chain (meaning more work to merge 8.0 targeted fixes). >> >> Please let Gabriel and I know how you feel about this date. I can see >> that >> master is still quite active, and I don't wish to make the work to >> stablize >> the 8.0 release any more difficult than it has to be. >> >> > > I think it would be good to make this week's release beta4 rather than rc1 > (without affecting the rest of the schedule). In that case we'd also push > back the branching and final ABI freeze two weeks. > > We're close to done with the warning to Error exception promotion task, > but haven't really started on reviewing and consolidating parameter names > yet (in preparation for named parameters). It would be good to have that > work mostly finalized before RC1, so we can limit the number of nominally > BC-breaking changes past RC1 (I expect we'll still fix some things that > slipped through the cracks, but at least we should prevent any mass > changes). > >
Yep. This seems like a reasonable adjustment to the schedule in order to finalize these features. I'll do beta4 tomorrow/thursday, and we should plan for RC1 branching in two weeks. Wiki ( https://wiki.php.net/todo/php80 ) has been updated to reflect this. Note that I have NOT moved the GA date at this time, as that would push us into Dec 10th. Though as the date approaches we may decide to add RC5 back in for safety despite the perinavidinal timing. -Sara P.S. Yes, I made that word up. You know which one.

Dmitry Stogov

5 years ago
This also gives me a time frame to clean up JIT code without hurry. I plan to separate the common JIT code, and merge JIT and VM helpers. Thanks. Dmitry. On Mon, Sep 14, 2020 at 5:55 PM Sara Golemon <pollita@php.net> wrote:

Brent

5 years ago
Hey Dmitiry Speaking of the JIT. I remember berblei mentioning that the JIT configuration options were going to change prior to the final 8 release (https://www.reddit.com/r/PHP/comments/hjxlh9/jit_benchmarks_on_reallife_web_applications/fwuje8g/ <https://www.reddit.com/r/PHP/comments/hjxlh9/jit_benchmarks_on_reallife_web_applications/fwuje8g/>). In other words: not one value with several integer flags, but dedicated options for every configuration entry. Is this still on the roadmap? Kind regards Brent

Sebastian Bergmann

5 years ago
Am 15.09.2020 um 08:19 schrieb Brent Roose:
> Is this still on the roadmap?
I hope so, too.

Benjamin Eberlei

5 years ago
On Tue, Sep 15, 2020 at 8:20 AM Brent Roose <brendt@stitcher.io> wrote:
> Hey Dmitiry > > Speaking of the JIT. I remember berblei mentioning that the JIT > configuration options were going to change prior to the final 8 release ( > https://www.reddit.com/r/PHP/comments/hjxlh9/jit_benchmarks_on_reallife_web_applications/fwuje8g/ > < > https://www.reddit.com/r/PHP/comments/hjxlh9/jit_benchmarks_on_reallife_web_applications/fwuje8g/>). > In other words: not one value with several integer flags, but dedicated > options for every configuration entry. Is this still on the roadmap? >
Hi Brent, Hi Sebastian, this is already done by this PR https://github.com/php/php-src/pull/5913 The options to talk about and use in docs/posts are the following: opcache.jit=yes|true|1 opcache.jit=tracing opcache.jit=function These differentiate the Tracing-JIT from the Function-JIT. Default is tracing.

Sebastian Bergmann

5 years ago
Am 15.09.2020 um 09:24 schrieb Benjamin Eberlei:
> The options to talk about and use in docs/posts are the following: > > opcache.jit=yes|true|1 > opcache.jit=tracing > opcache.jit=function > > These differentiate the Tracing-JIT from the Function-JIT. Default is > tracing.
Thanks!

Christoph Becker

5 years ago
On 15.09.2020 at 09:29, Sebastian Bergmann wrote:
> Am 15.09.2020 um 09:24 schrieb Benjamin Eberlei: >> The options to talk about and use in docs/posts are the following: >> >> opcache.jit=yes|true|1 >> opcache.jit=tracing >> opcache.jit=function >> >> These differentiate the Tracing-JIT from the Function-JIT. Default is >> tracing. > > Thanks!
See also <https://github.com/php/doc-en/pull/140>.
-- Christoph M. Becker