Everything

php

ZEND_ENGINE_4

php.internals

Sara Golemon

5 years ago

Maybe just a wee bit late to ask this question, but shouldn't we have long
since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ?

Was that deliberate since (unlike with 4->5 and 5->7) the engine's API
surface area hasn't skewed so bad?

I ask because ZEND_VERSION did get updated to the 4.x.x series.

-Sara

Girgias

5 years ago

On Thu, 26 Nov 2020 at 02:42, Sara Golemon <pollita@php.net> wrote:

> Maybe just a wee bit late to ask this question, but shouldn't we have long
> since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ?
>
> Was that deliberate since (unlike with 4->5 and 5->7) the engine's API
> surface area hasn't skewed so bad?
>
> I ask because ZEND_VERSION did get updated to the 4.x.x series.
>
> -Sara
>

Wasn't there discussion about dropping the ZEND_ENGINE_* constant?
As the Zend API changes between minor versions it is debatable how better
it is to check for that constant instead of a version number.

Best,

George P. Banyard

Remi Collet

5 years ago

Le 26/11/2020 à 03:41, Sara Golemon a écrit :

> Maybe just a wee bit late to ask this question, but shouldn't we have long
> since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ?

From a quick search I see some usage of ZEND_ENGINE_3
(eg, imagick and gmagick ext, probably others)

> Was that deliberate since (unlike with 4->5 and 5->7) the engine's API
> surface area hasn't skewed so bad?

Indeed,

This is mostly used to test for PHP 5 vs 7/8 API

>
> I ask because ZEND_VERSION did get updated to the 4.x.x series.

IMHO, we should keep ZEND_ENGINE_3 to not break things so late
and encourage dev to not use it anymore

And drop it in 8.1 (without ZEND_ENGINE_4)

Remi

>
> -Sara
>

P.S. https://github.com/Imagick/imagick/pull/363

Dmitry Stogov

5 years ago

We don't need ZEND_ENGINE_4 for PHP 8.*.
PHP 8.0 didn't introduce revolutionary engine changes (like PHP 7 and PHP 5
did), and we won't introduce big engine changes in minor releases.

Thanks. Dmitry.

On Thu, Nov 26, 2020 at 11:44 AM Remi Collet <remi@php.net> wrote:

Sara Golemon

5 years ago

On Thu, Nov 26, 2020 at 7:31 AM Dmitry Stogov <dmitrystogov@gmail.com>
wrote:

> We don't need ZEND_ENGINE_4 for PHP 8.*.
> PHP 8.0 didn't introduce revolutionary engine changes (like PHP 7 and PHP 5
> did), and we won't introduce big engine changes in minor releases.
>
>

Yeah, I've been reminded that we had this discussion months ago.  Thanks
for the reply. :D

-Sara