Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » Potential RFC around PDO »

Potential RFC around PDO

php.internals

Daniel Beardsley

5 years ago
wiki username: danielbeardsley === Background I was told to introduce myself. I've been in software development for more than 20 years and have been working with php for 10 or so of that. I've only had a little contact with this group, but I've got at least one past pull merged on the php-src repo: https://github.com/php/php-src/pull/271. At iFixit we use a forked version of php with a small change to allow automatically html-escaping echoed strings: https://github.com/iFixit/php-src/commit/cb6eb5c35a07c843e5b357884186d77e3a1a2981 . It's not something this list would be interested in as it's rather special-purpose, but I'm mentioning it to show I'm somewhat familiar with the php build system. === Why I'm emailing now: I've opened a pull request on php-src: https://github.com/php/php-src/pull/6677 and I've been advised to make an RFC. The first step is emailing! I'd like to propose adding a function to the mysql pdo driver (in the same way postgres and sqlite have) to extract the count of warnings from the last executed statement. See the pull request linked above for a more thorough description. Should I make an RFC out of this? Thanks for your time! Daniel Beardsley

Mark Randall

5 years ago
On 18/02/2021 00:57, Daniel Beardsley wrote:
> At iFixit we use a forked version of php with a small change to allow > automatically html-escaping echoed strings: > https://github.com/iFixit/php-src/commit/cb6eb5c35a07c843e5b357884186d77e3a1a2981
Long ago, PHP had a similar feature called Magic Quotes. It is now universally considered to be among the worst and most damaging features that PHP ever introduced. There is no apetite to reintroduce such a thing. Mark Randall

Mark Randall

5 years ago
On 18/02/2021 03:37, Mark Randall wrote:
> Long ago, PHP had a similar feature called Magic Quotes.
My apologies, I had only that top paragraph visible in my preview and responded to entirely the wrong part of your post :-(

Christoph Becker

5 years ago
Hi Daniel! On 18.02.2021 at 01:57, Daniel Beardsley wrote:
> wiki username: danielbeardsley > > === Background > I was told to introduce myself. I've been in software development for more > than 20 years and have been working with php for 10 or so of that. I've > only had a little contact with this group, but I've got at least one past > pull merged on the php-src repo: https://github.com/php/php-src/pull/271. > At iFixit we use a forked version of php with a small change to allow > automatically html-escaping echoed strings: > https://github.com/iFixit/php-src/commit/cb6eb5c35a07c843e5b357884186d77e3a1a2981 > . It's not something this list would be interested in as it's rather > special-purpose, but I'm mentioning it to show I'm somewhat familiar with > the php build system. > > === Why I'm emailing now: > I've opened a pull request on php-src: > https://github.com/php/php-src/pull/6677 and I've been advised to make an > RFC. The first step is emailing! > > I'd like to propose adding a function to the mysql pdo driver (in the same > way postgres and sqlite have) to extract the count of warnings from the > last executed statement. > > See the pull request linked above for a more thorough description. > > Should I make an RFC out of this?
Yes, I think this needs an RFC, because adding driver specific methods is rather controversial. See e.g. <https://externals.io/message/100773>. Anyhow, RFC karma has been granted.
-- Christoph