Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » Unbreak git.php.net links? »

Unbreak git.php.net links?

php.internals

Stas Malyshev

4 years ago
Hi! I know we're no longer using git.php.net, but there are a lot of links there e.g. in bugs system. I wonder how hard it would be to make git.php.net redirect links like this: http://git.php.net/?p=php-src.git;a=commit;h=3c939e3f69955d087e0bb671868f7267dfb2a502 to something like: https://github.com/php/php-src/commit/3c939e3f69955d087e0bb671868f7267dfb2a502
-- Stas Malyshev smalyshev@gmail.com

Joe Watkins

4 years ago
This seems reasonable. I wonder if we could log the redirects so that we can obtain the list of links and update accordingly so that we may eventually retire the domain without breaking stuff. Cheers Joe On Monday, 4 October 2021, Stanislav Malyshev <smalyshev@gmail.com> wrote:

Joe Watkins

4 years ago
I just realised you're probably talking mostly about links in old comments on bugs rather than in source code of bugsnet (because they would be easy to find). Maybe permanent redirects aren't so bad in that case. But also, can't we just update the comments in place? Cheers Joe On Monday, 4 October 2021, Joe Watkins <krakjoe@gmail.com> wrote:

Stas Malyshev

4 years ago
Hi! On 10/3/21 9:48 PM, Joe Watkins wrote:
> I just realised you're probably talking mostly about links in old > comments on bugs rather than in source code of bugsnet (because they > would be easy to find). > > Maybe permanent redirects aren't so bad in that case. > > But also, can't we just update the comments in place?
Well, that's possible too but I imagine it'd be more work.
-- Stas Malyshev smalyshev@gmail.com

Hans Henrik Bergan

4 years ago
there's also plenty of broken links on reddit to git.php.net , ref https://www.google.com/search?q=git.php.net+site%3Areddit.com it wouldn't be hard to set up a redirector parsing commit ids out of the url and redirecting to github, +1 from me. On Mon, 4 Oct 2021 at 07:04, Stanislav Malyshev <smalyshev@gmail.com> wrote:

Andreas Heigl

4 years ago
Hey all. On 04.10.21 07:52, Hans Henrik Bergan wrote:
> there's also plenty of broken links on reddit to git.php.net , ref > https://www.google.com/search?q=git.php.net+site%3Areddit.com > > it wouldn't be hard to set up a redirector parsing commit ids out of the > url and redirecting to github, > +1 from me.
So who's going to work on it? Doesn't make sense to have 5 people work on it independently from each other ;-) Cheers Andreas
-- ,,, (o o) +---------------------------------------------------------ooO-(_)-Ooo-+ | Andreas Heigl | | mailto:andreas@heigl.org N 50°22'59.5" E 08°23'58" | | https://andreas.heigl.org | +---------------------------------------------------------------------+ | https://hei.gl/appointmentwithandreas | +---------------------------------------------------------------------+

Joe Watkins

4 years ago
I didn't think about external links ... I guess then redirecting would be best. The nameserver configuration is still as it was (I think), so it's probably best to setup the NS to point at web and then someone can do the work in the web repo (I suppose). Cheers Joe On Mon, 4 Oct 2021 at 08:01, Andreas Heigl <andreas@heigl.org> wrote:

Hans Henrik Bergan

4 years ago
>So who's going to work on it? Doesn't make sense to have 5 people work > on it independently from each other ;-)
if nobody else wants to do it, i can make an initial implementation on october 9th (6 days from now), but wouldn't surprise me at all if someone else wants to do it ^^ On Mon, 4 Oct 2021 at 08:01, Andreas Heigl <andreas@heigl.org> wrote:

Hans Henrik Bergan

4 years ago
here is an initial implementation: https://github.com/divinity76/git-php-net-redirector/blob/main/src/redirector.php it is just a minimum-effort implementation, anyone feel free to make something better (also i have no idea how the "p" argument is supposed to be parsed, so i just guessed) it passes "Stanislav Malyshev"'s initial sample url, but it probably fails on any other formats, if anyone has test urls, share em On Mon, 4 Oct 2021 at 08:38, Hans Henrik Bergan <divinity76@gmail.com> wrote:

Ayesh - PHP.Watch

4 years ago
> here is an initial implementation: > https://github.com/divinity76/git-php-net-redirector/blob/main/src/redirector.php > it is just a minimum-effort implementation, anyone feel free to make > something better (also i have no idea how the "p" argument is supposed to > be parsed, so i just guessed) > > it passes "Stanislav Malyshev"'s initial sample url, but it probably fails > on any other formats, if anyone has test urls, share em > > > > On Mon, 4 Oct 2021 at 08:38, Hans Henrik Bergan <divinity76@gmail.com> > wrote: > > > >So who's going to work on it? Doesn't make sense to have 5 people work > > > on it independently from each other ;-) > > > > if nobody else wants to do it, i can make an initial implementation on > > october 9th (6 days from now), > > > > but wouldn't surprise me at all if someone else wants to do it ^^ > > > > > > On Mon, 4 Oct 2021 at 08:01, Andreas Heigl <andreas@heigl.org> wrote: > > > >> Hey all. > >> > >> On 04.10.21 07:52, Hans Henrik Bergan wrote: > >> > there's also plenty of broken links on reddit to git.php.net , ref > >> > https://www.google.com/search?q=git.php.net+site%3Areddit.com > >> > > >> > it wouldn't be hard to set up a redirector parsing commit ids out of the > >> > url and redirecting to github, > >> > +1 from me. > >> > >> So who's going to work on it? Doesn't make sense to have 5 people work > >> on it independently from each other ;-) > >> > >> Cheers > >> > >> Andreas > >> -- > >> ,,, > >> (o o) > >> +---------------------------------------------------------ooO-(_)-Ooo-+ > >> | Andreas Heigl | > >> | mailto:andreas@heigl.org N 50°22'59.5" E 08°23'58" | > >> | https://andreas.heigl.org | > >> +---------------------------------------------------------------------+ > >> | https://hei.gl/appointmentwithandreas | > >> +---------------------------------------------------------------------+ > >> > >
Hi Stanislav/Hans, Thanks for opening this conversation and the initial implementation. Having worked with a few cgit repositories before, I happen to recall some of the other URL patterns. I worked on a similar implementation to Hans's at https://github.com/Ayesh/git-php-redirect
> something better (also i have no idea how the "p" argument is supposed to > be parsed, so i just guessed)
It is the name of the git repository on git.php.net. There were several other repos for PECL, bug tracker, docs in multiple languages, etc. I have added support for a static list that maps git.php.net names to GitHub repo under `php` organization namespace. In addition to the URL patterns Hans have covered (p=php-src;h=HEX{40}), I thought to add a few more patterns: - FROM: http://git.php.net/?p=php-src.git;a=commit;h=5af586be ( `/[a-z0-9]{7,}$/` ) TO: https://github.com/php/php-src/commit/5af586be - FROM: https://git.php.net/?p=php-src.git;a=shortlog;h=refs/tags/php-8.0.0RC2 TO: https://github.com/php/php-src/releases/tag/php-8.1.0RC3 - FROM: https://git.php.net/?p=php-src.git;a={tree,log,shortlog};h=refs/heads/master;hb=refs/heads/master TO: https://github.com/php/php-src/{tree,commits,commits}/master - FROM: http://git.php.net/?p=php-src.git;a=log TO: https://github.com/php/php-src Cheers, Ayesh.

Hans Henrik Bergan

4 years ago
@Ayesh thanks, added support for those url ( https://github.com/divinity76/git-php-net-redirector/commit/072a579d140a7481e76e95bd8c2d120ee2f71565 ), also it looks like version numbers got mixed up in your example #2 , "8.0.0RC2" vs "8.1.0RC3", that is surely a typo?
>It is the name of the git repository on git.php.net. There were
several other repos for PECL, bug tracker, docs in multiple languages, etc. I have added support for a static list that maps git.php.net names to GitHub repo under `php` organization namespace. oh i see. fwiw, your implementation looks more professional / enterprise-y :) On Tue, 5 Oct 2021 at 15:43, Ayesh Karunaratne <ayesh@php.watch> wrote: