Everything

php

Home » Project » Newsgroups » php.internals » Re: How to deal with bugs in vendored libraries? »

Re: How to deal with bugs in vendored libraries?

php.internals

Michael Voříšek - ČVUT FJFI

3 years ago

One good way to maintain some quality standard is to enforce it thru CI
:)

This also applies to https://github.com/php/php-src/pull/10549/files and
https://github.com/php/php-src/pull/10531/files for example, such
problems should fail the CI and enforce the contributors to fix the code
before the changes are merged.

With kind regards / Mit freundlichen Grüßen / S přátelským pozdravem,

Michael Voříšek

On 9 Feb 2023 14:14, Max Kellermann wrote:

Max Kellermann

3 years ago

On 2023/02/09 14:49, Michael Voříšek - ČVUT FJFI <vorismi3@fjfi.cvut.cz> wrote:

> One good way to maintain some quality standard is to enforce it thru CI

Agree, the CI is a nice tool for enforcing certain policies, but first
there needs to be a decision on what is the desired quality standard.

Finding such a decision is why I posted here; so far, nobody replied
to that.

Max