Everything

php

[RFC] [Discussion] XML_OPTION_PARSE_HUGE

php.internals

Niels Dossche

2 years ago

Hi internals

I'd like to put a new RFC under discussion:
https://wiki.php.net/rfc/xml_option_parse_huge

Kind regards
Niels

Larry Garfield

2 years ago

On Thu, Sep 21, 2023, at 9:26 PM, Niels Dossche wrote:

> Hi internals
>
> I'd like to put a new RFC under discussion:
> https://wiki.php.net/rfc/xml_option_parse_huge
>
> Kind regards
> Niels

Seems reasonable to me at first glance.  Some code samples in the RFC showing usage would help.  It would also help to know what the actual definition of huge is right now; just referencing a header file in some other library doesn't help me. :-)

--Larry Garfield

Niels Dossche

2 years ago

Hi Larry

On 22/09/2023 01:05, Larry Garfield wrote:

> On Thu, Sep 21, 2023, at 9:26 PM, Niels Dossche wrote:
>> Hi internals
>>
>> I'd like to put a new RFC under discussion:
>> https://wiki.php.net/rfc/xml_option_parse_huge
>>
>> Kind regards
>> Niels
>
> Seems reasonable to me at first glance.  Some code samples in the RFC showing usage would help.  It would also help to know what the actual definition of huge is right now; just referencing a header file in some other library doesn't help me. :-)

Will do both, thanks.

>
> --Larry Garfield
>

Kind regards
Niels

A.L.E.C

2 years ago

On 21.09.2023 23:26, Niels Dossche wrote:

> I'd like to put a new RFC under discussion:
> https://wiki.php.net/rfc/xml_option_parse_huge

Looking at LIBXML_PARSEHUGE at
https://www.php.net/manual/en/libxml.constants.php

- there's discrepancy regarding the libxml version the feature was
introduced in,
- maybe existence of this constant should be mentioned in the RFC.

--
Aleksander Machniak
Kolab Groupware Developer        [https://kolab.org]
Roundcube Webmail Developer  [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com

Niels Dossche

2 years ago

Hi Aleksander

On 22/09/2023 07:51, Aleksander Machniak wrote:

> On 21.09.2023 23:26, Niels Dossche wrote:
>> I'd like to put a new RFC under discussion:
>> https://wiki.php.net/rfc/xml_option_parse_huge
>
> Looking at LIBXML_PARSEHUGE at https://www.php.net/manual/en/libxml.constants.php
>
> - there's discrepancy regarding the libxml version the feature was introduced in,

I'll fix this, it should indeed be 2.7.0.

> - maybe existence of this constant should be mentioned in the RFC.
>

Agreed, I'll add this.

Thanks for noticing these.

Cheers
Niels

Niels Dossche

2 years ago

On 9/21/23 23:26, Niels Dossche wrote:

> Hi internals
>
> I'd like to put a new RFC under discussion:
> https://wiki.php.net/rfc/xml_option_parse_huge
>
> Kind regards
> Niels

Hi internals

It's been two weeks, I'd like to start the vote tomorrow evening.
Please raise any last complaints now.

Thanks
Niels