Everything

php

Request PHP 8.3 GA release push back

php.internals

Girgias

2 years ago

Hello internals,

As far as I am aware, the 8.3.0 release is meant to be tagged tomorrow.

However, there are at least three known bugs in RC6:

- An ext/posix bug [1], which has a fix [2]
- Two ext/pgsql bugs around the new pipeline support:
- A constant not being exposed [3]
- The overall implementation having issues [4]

Sincerely,

Gina P. Banyard

[1] https://github.com/php/php-src/issues/12725
[2] https://github.com/php/php-src/pull/11774
[3] https://github.com/php/php-src/issues/9344
[4] https://github.com/php/php-src/pull/12731

Saki Takamachi

2 years ago

> As far as I am aware, the 8.3.0 release is meant to be tagged tomorrow.
>
> However, there are at least three known bugs in RC6:
>
> - An ext/posix bug [1], which has a fix [2]
> - Two ext/pgsql bugs around the new pipeline support:
>  - A constant not being exposed [3]
>  - The overall implementation having issues [4]
>
> Sincerely,
>
> Gina P. Banyard
>
> [1] https://github.com/php/php-src/issues/12725
> [2] https://github.com/php/php-src/pull/11774
> [3] https://github.com/php/php-src/issues/9344
> [4] https://github.com/php/php-src/pull/12731

Hi Gina,

I agree for push back, these bugs are the enough reason to do.

Regards.

Saki

Jakub Zelenka

2 years ago

Hi

On Mon, Nov 20, 2023 at 1:16 PM G. P. B. <george.banyard@gmail.com> wrote:

>
> - An ext/posix bug [1], which has a fix [2]
>

I just merged this as it was also confirmed by OP that it fixes the issue
so this should be now sorted hopefully.

> - Two ext/pgsql bugs around the new pipeline support:
>   - A constant not being exposed [3]
>   - The overall implementation having issues [4]
>
>

So I just had a look and I think we should revert the whole pipeline
addition. Those fixes are introducing new functions [1] / constants and
that should just not be happening in RC stage. The whole thing seems
incomplete to me so I think I'm going revert it from 8.3.

It might still need a bit of discussion so I will discuss with other RM's
if we want to create one more RC.

[1]
https://github.com/php/php-src/commit/63898008c0153b4b89d166b647694d5ec45d7797

Cheers

Jakub

Jakub Zelenka

2 years ago

On Mon, Nov 20, 2023 at 1:55 PM Jakub Zelenka <bukka@php.net> wrote:

> Hi
>
> On Mon, Nov 20, 2023 at 1:16 PM G. P. B. <george.banyard@gmail.com> wrote:
>
>>
>> - An ext/posix bug [1], which has a fix [2]
>>
>
> I just merged this as it was also confirmed by OP that it fixes the issue
> so this should be now sorted hopefully.
>
>
>> - Two ext/pgsql bugs around the new pipeline support:
>>   - A constant not being exposed [3]
>>   - The overall implementation having issues [4]
>>
>>
> So I just had a look and I think we should revert the whole pipeline
> addition. Those fixes are introducing new functions [1] / constants and
> that should just not be happening in RC stage. The whole thing seems
> incomplete to me so I think I'm going revert it from 8.3.
>
>

Revert PR created: https://github.com/php/php-src/pull/12735

Jakub Zelenka

2 years ago

On Mon, Nov 20, 2023 at 2:10 PM Jakub Zelenka <bukka@php.net> wrote:

> On Mon, Nov 20, 2023 at 1:55 PM Jakub Zelenka <bukka@php.net> wrote:
>
>> Hi
>>
>> On Mon, Nov 20, 2023 at 1:16 PM G. P. B. <george.banyard@gmail.com>
>> wrote:
>>
>>>
>>> - An ext/posix bug [1], which has a fix [2]
>>>
>>
>> I just merged this as it was also confirmed by OP that it fixes the issue
>> so this should be now sorted hopefully.
>>
>>
>>> - Two ext/pgsql bugs around the new pipeline support:
>>>   - A constant not being exposed [3]
>>>   - The overall implementation having issues [4]
>>>
>>>
>> So I just had a look and I think we should revert the whole pipeline
>> addition. Those fixes are introducing new functions [1] / constants and
>> that should just not be happening in RC stage. The whole thing seems
>> incomplete to me so I think I'm going revert it from 8.3.
>>
>>
>  Revert PR created: https://github.com/php/php-src/pull/12735
>

We discusses this internally and the revert got approved and merged so all
known issues are sorted and there is no need for the release push back.

Cheers

Jakub