Everything

php

Adding attributes to compile-time constants

php.internals

Daniel Scherzer

1 year ago

Hi internals,

For the last few weeks, I've been working on a patch[1] that I just
uploaded that adds support for attributes on compile-time non-class
constants (those declared with `const` rather than via `define()`). The
patch has a memory leak that I have been unable to resolve, but otherwise
the functionality is there and seems to work. Is anyone willing to help
with the memory issue?

Separately, once the memory issue is fixed, would this need to go through
an RFC process?

Thanks,
--Daniel Scherzer

[1] https://github.com/php/php-src/pull/16952

Larry Garfield

1 year ago

On Tue, Nov 26, 2024, at 2:15 PM, Daniel Scherzer wrote:

> Hi internals,
>
> For the last few weeks, I've been working on a patch[1] that I just
> uploaded that adds support for attributes on compile-time non-class
> constants (those declared with `const` rather than via `define()`). The
> patch has a memory leak that I have been unable to resolve, but
> otherwise the functionality is there and seems to work. Is anyone
> willing to help with the memory issue?
>
> Separately, once the memory issue is fixed, would this need to go
> through an RFC process?
>
> Thanks,
> --Daniel Scherzer
>
> [1] https://github.com/php/php-src/pull/16952

I believe it would require an RFC, though I expect it would pass easily.  I'm no help on the memory question though, I'm afraid.

--Larry Garfield

Tim Düsterhus

1 year ago

Hi

Am 2024-11-26 21:39, schrieb Larry Garfield:

> I believe it would require an RFC, though I expect it would pass
> easily.

I agree. Attributes on regular constants introduce new syntax, which is
a pretty clear language change and thus requires an RFC.

Best regards
Tim Düsterhus

Daniel Scherzer

1 year ago

Since it seems that this requires an RFC, I have created an account on
wiki.php.net with the username `danielescherzer` and kindly request edit
privileges so that I can create the RFC.

-Daniel

On Tue, Nov 26, 2024 at 12:15 PM Daniel Scherzer <
daniel.e.scherzer@gmail.com> wrote:

Christoph Becker

1 year ago

On 30.11.2024 at 11:59, Daniel Scherzer wrote:

> Since it seems that this requires an RFC, I have created an account on
> wiki.php.net with the username `danielescherzer` and kindly request edit
> privileges so that I can create the RFC.

RFC karma granted.  Best of luck with the RFC!

Christoph