Everything

php

Home » Project » Newsgroups » php.internals » [RFC] [Discussion] FILTER_THROW_ON_FAILURE »

[RFC] [Discussion] FILTER_THROW_ON_FAILURE

php.internals

Daniel Scherzer

1 year ago

Hi internals,

I'd like to start the discussion for a new RFC about adding
a FILTER_THROW_ON_FAILURE flag to the filter extension.

* RFC: https://wiki.php.net/rfc/filter_throw_on_failure
* Implementation: https://github.com/php/php-src/pull/18896

--Daniel

Derick Rethans

1 year ago

On Sat, 5 Jul 2025, Daniel Scherzer wrote:

> Hi internals,
>
> I'd like to start the discussion for a new RFC about adding
> a FILTER_THROW_ON_FAILURE flag to the filter extension.
>
> * RFC: https://wiki.php.net/rfc/filter_throw_on_failure
> * Implementation: https://github.com/php/php-src/pull/18896

I think this is an excellent idea.

I left a review on the PR, with a suggestion to improve the exception
message (slightly):
https://github.com/php/php-src/pull/18896/files#r2204824115

cheers,
Derick

Daniel Scherzer

1 year ago

On Sat, Jul 5, 2025 at 4:23 PM Daniel Scherzer <daniel.e.scherzer@gmail.com>
wrote:

> Hi internals,
>
> I'd like to start the discussion for a new RFC about adding
> a FILTER_THROW_ON_FAILURE flag to the filter extension.
>
> * RFC: https://wiki.php.net/rfc/filter_throw_on_failure
> * Implementation: https://github.com/php/php-src/pull/18896
>
> --Daniel
>

Given the lack of further feedback outside of discussing the exception
message, either here or on GitHub, I plan to open the vote in the next few
days.

-Daniel