Everything

php

Home » Project » Newsgroups » php.internals » Tidy, CS, OO, Vote »

Tidy, CS, OO, Vote

php.internals

John Coggeshall

22 years ago

Alright..

I've got a patch sitting here on my laptop that converts all of the OO
syntax in the tidy extension into studlyCaps. I.e.

$tidy = tidy_parse_file();

or

$tidy = new tidy();
$tidy->parse_file();

Will become..

$tidy = tidy_parse_file()

or

$tidy = new tidy();
$tidy->parseFile();

Although my *personal* preference here is to maintain the current use of
underscores (since it is consistent with the procedural API).. as far as
PHP 5 goes itself I don't really have an opinion. I'm willing to apply
this patch, but before I do can I please get a +1 -1 vote on this?
*please* no discussion, I just want to be done changing the API so the
documentation team can actually do something productive.

John

--
-=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-
John Coggeshall                   http://www.coggeshall.org/
The PHP Developer's Handbook    http://www.php-handbook.com/
-=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-

Marcus Börger

22 years ago

Hello John,

Wednesday, January 21, 2004, 9:00:39 AM, you wrote:

> Alright..

> I've got a patch sitting here on my laptop that converts all of the OO
> syntax in the tidy extension into studlyCaps. I.e.

> 	$tidy = tidy_parse_file();

> 	or

> 	$tidy = new tidy();
> 	$tidy->parse_file();

> Will become..

> 	$tidy = tidy_parse_file()

> 	or

> 	$tidy = new tidy();
> 	$tidy->parseFile();

> Although my *personal* preference here is to maintain the current use of
> underscores (since it is consistent with the procedural API).. as far as
> PHP 5 goes itself I don't really have an opinion. I'm willing to apply
> this patch, but before I do can I please get a +1 -1 vote on this?

+1

> *please* no discussion, I just want to be done changing the API so the
> documentation team can actually do something productive.

--
Best regards,
Marcus                            mailto:helly@php.net

Sascha Schumann

22 years ago

> PHP 5 goes itself I don't really have an opinion. I'm willing to apply
> this patch, but before I do can I please get a +1 -1 vote on this?

-1

There really is no reason to convert existing code.

- Sascha

Jon Parise

22 years ago

On Wed, Jan 21, 2004 at 03:00:39AM -0500, John Coggeshall wrote:

> Although my *personal* preference here is to maintain the current use of
> underscores (since it is consistent with the procedural API).. as far as
> PHP 5 goes itself I don't really have an opinion. I'm willing to apply
> this patch, but before I do can I please get a +1 -1 vote on this?

+0 (I'm comfortable either way with a preference for consistency.)

--
Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)

Andi Gutmans

22 years ago

Go ahead with it.
Please commit it.
I hope Sascha will relax with another one of his holy wars.

Andi

At 03:00 AM 1/21/2004 -0500, John Coggeshall wrote:

John Coggeshall

22 years ago

On Wed, 2004-01-21 at 05:04, Andi Gutmans wrote:

> Go ahead with it.
> Please commit it.
> I hope Sascha will relax with another one of his holy wars.

Done.

--
-=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-
John Coggeshall                   http://www.coggeshall.org/
The PHP Developer's Handbook    http://www.php-handbook.com/
-=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-