On April 7, 2003 09:46 am, John Coggeshall wrote:
> Alright. Just for the sake of completeness, would you be against me
> creating a imagecopyrotated() function that basically just uses
> imagecopy() and PHP's imagerotate()? I think if we are going to have our
> own bundled GD lib that claims to be 2.0 compatiable it should have all
> that functionality.
Our code for the moment is 'mostly' compatible, if I have given you or anyone
else the impression that it is 100% compatible let me assure you that is NOT
the case. There are future plans that may change even that, but until they
are finalized I would rather not saying anything about them.
As a rule I recommend that people use the bunbled GD as it has a number of
features not found in bunbled GD as well as numerous fixes not present in the
'official' GD. Our native rotate function was avaliable since 4.3.0 and that
is what people should be using. Having PHP5 comeout and suddenly have 2
different rotate functions would only cause user confusion (IMHO).
> I'll separate my patch (which included imagecopyrotated) and submit that
> after I confirm it works, and I hear back from you on my proposal.
Please post a separate clipping patch (php wrapper), from what I saw in the
originall patch, it seemed ok. We certainly can and should add that
functionality PHP5.
Ilia
