On Tue, 2003-04-08 at 08:41, Derick Rethans wrote:
> On Mon, 7 Apr 2003, Rasmus Lerdorf wrote:
>
> > I think this should go in. Like you said, for anything long-running, the
> > current domxml is almost useless, so I would consider this a bug fix.
>
> Yup, me too.
Patch is commited, please test it, if you're dependent on domxml ;)
chregu
>
> Derick
>
> >
> > -Rasmus
> >
> > On 8 Apr 2003, Christian Stocker wrote:
> >
> > > Hi
> > >
> > > (Mainly) Rob Richards and (just a tiny little bit) me were hunting down
> > > some domxml memleaks (and Rob implemented DomDocument->free() method.
> > > Hooray ;) ). As we are rather late in the release process of PHP 4.3.2,
> > > I'm not sure, if it's wise to commit them now to the PHP_4_3 branch or
> > > if I should wait until after this release.
> > >
> > > Furthermore, the DomDocument->free() method was a much asked feature for
> > > domxml (and it really helps saving memory, if you want to process a lot
> > > of XML-Documents in one run). Would it be totally against the release
> > > rule if I add that function after 4.3.2 is released to the PHP_4_3
> > > branch?
> > >
> > > Anyway, the diff file (against ext/domxml HEAD, not PHP_4_3 for the time
> > > being) can be found at http://trash.chregu.tv/domxml.memleak.diff, if
> > > anyone wants to use/test it right now
> > >
> > > chregu
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
--
christian stocker | bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71
http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB