Patch for making static method calls work from within xslt

php.internals

Christian Stocker

22 years ago
Hi I made a patch for making static php method calls (ala class::method) work from within xslt. (see http://slides.bitflux.ch/phpug2004_1/slide_37.html for some details about this technique) I'm not sure, if I can commit that now in this stage of the release process. Would be great, if it would make it into 5.0.0. The patch is here http://trash.chregu.tv/staticmethod-xsl.diff a non whitespace-changes diff here: http://trash.chregu.tv/staticmethod-xsl.non-withespace.diff chregu
-- christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB

Andi Gutmans

22 years ago
Hi, From looking at the non-whitespace diff I don't quite understand what you changed (except for adding an error message if it's not callable). What am I missing? Andi At 11:00 AM 4/20/2004 +0200, Christian Stocker wrote:

Christian Stocker

22 years ago
On 4/20/04 11:05 AM, Andi Gutmans wrote:
> Hi, > > From looking at the non-whitespace diff I don't quite understand what > you changed (except for adding an error message if it's not callable). > What am I missing?
the zend_make_callable() was missing. it didn't work without that. chregu
> > Andi > > At 11:00 AM 4/20/2004 +0200, Christian Stocker wrote: > >> Hi >> >> I made a patch for making static php method calls (ala class::method) >> work from within xslt. >> (see http://slides.bitflux.ch/phpug2004_1/slide_37.html for some >> details about this technique) >> >> I'm not sure, if I can commit that now in this stage of the release >> process. Would be great, if it would make it into 5.0.0. >> >> The patch is here >> http://trash.chregu.tv/staticmethod-xsl.diff >> >> a non whitespace-changes diff here: >> http://trash.chregu.tv/staticmethod-xsl.non-withespace.diff >> >> chregu >> >> >> >> -- >> christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich >> phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 >> http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php > >
-- christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB

Andi Gutmans

22 years ago
Oh :) I thought that was zend_is_callable(). I'm OK with you commiting this. It's a small one and quite useful. Andi At 11:11 AM 4/20/2004 +0200, Christian Stocker wrote:

Christian Stocker

22 years ago
On 4/20/04 11:19 AM, Andi Gutmans wrote:
> Oh :) I thought that was zend_is_callable(). > I'm OK with you commiting this. It's a small one and quite useful.
Thanks. Comited. chregu
> > Andi > > At 11:11 AM 4/20/2004 +0200, Christian Stocker wrote: > > >> On 4/20/04 11:05 AM, Andi Gutmans wrote: >> >>> Hi, >>> From looking at the non-whitespace diff I don't quite understand >>> what you changed (except for adding an error message if it's not >>> callable). What am I missing? >> >> >> the zend_make_callable() was missing. it didn't work without that. >> >> chregu >> >> >>> Andi >>> At 11:00 AM 4/20/2004 +0200, Christian Stocker wrote: >>> >>>> Hi >>>> >>>> I made a patch for making static php method calls (ala >>>> class::method) work from within xslt. >>>> (see http://slides.bitflux.ch/phpug2004_1/slide_37.html for some >>>> details about this technique) >>>> >>>> I'm not sure, if I can commit that now in this stage of the release >>>> process. Would be great, if it would make it into 5.0.0. >>>> >>>> The patch is here >>>> http://trash.chregu.tv/staticmethod-xsl.diff >>>> >>>> a non whitespace-changes diff here: >>>> http://trash.chregu.tv/staticmethod-xsl.non-withespace.diff >>>> >>>> chregu >>>> >>>> >>>> >>>> -- >>>> christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich >>>> phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 >>>> http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB >>>> >>>> -- >>>> PHP Internals - PHP Runtime Development Mailing List >>>> To unsubscribe, visit: http://www.php.net/unsub.php >> >> >> -- >> christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich >> phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 >> http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB > >
-- christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB