flex version

php.internals

Per Lundberg

23 years ago
Hello PHP hackers, What version of flex is needed to compile PHP5 from CVS? My version bails out like this: [Thu Apr 17 10:58:15] per@salem:/usr/local/src/php-cvs/php5> make Zend/zend_language_scanner.c flex -Pzend -S/usr/local/src/php-cvs/php5/Zend/flex.skl -oZend/zend_language_scanner.c -i /usr/local/src/php-cvs/php5/Zend/zend_language_scanner.l flex: fatal internal error, bad line in skeleton file make: *** [Zend/zend_language_scanner.c] Error 1 [Thu Apr 17 11:09:44] per@salem:/usr/local/src/php-cvs/php5> flex -V flex 2.5.31 [Thu Apr 17 11:10:04] per@salem:/usr/local/src/php-cvs/php5> dpkg -l flex [...] ii flex 2.5.31-3 A fast lexical analyzer generator.
-- Best regards, Per Lundberg / Capio ApS Phone: +46-18-4186040 Fax: +46-18-4186049 Web: http://www.nobolt.com

Derick Rethans

23 years ago
On Thu, 17 Apr 2003, Per Lundberg wrote:
> What version of flex is needed to compile PHP5 from CVS? My version > bails out like this:
You need 2.5.4 (configure warns about this btw) Derick
-- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------

Per Lundberg

23 years ago
On Thu, 2003-04-17 at 11:11, Derick Rethans wrote:
> > What version of flex is needed to compile PHP5 from CVS? My version > > bails out like this: > You need 2.5.4 (configure warns about this btw)
It doesn't warn me, and obviously, 2.5.31 > 2.5.4 so it should not... Still, this version does not seem good.
-- Best regards, Per Lundberg / Capio ApS Phone: +46-18-4186040 Fax: +46-18-4186049 Web: http://www.nobolt.com

Derick Rethans

23 years ago
On Thu, 17 Apr 2003, Per Lundberg wrote:
> On Thu, 2003-04-17 at 11:11, Derick Rethans wrote: > > > What version of flex is needed to compile PHP5 from CVS? My version > > > bails out like this: > > You need 2.5.4 (configure warns about this btw) > > It doesn't warn me, and obviously, 2.5.31 > 2.5.4 so it should not...
I should warn you, as 2.5.31 is borked. And I'm pretty sure the check is in (perhaps when you run ./buildconf though). Derick
-- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------

Per Lundberg

23 years ago
On Thu, 2003-04-17 at 11:17, Derick Rethans wrote:
> On Thu, 17 Apr 2003, Per Lundberg wrote: > > It doesn't warn me, and obviously, 2.5.31 > 2.5.4 so it should not... > I should warn you, as 2.5.31 is borked.
Yes, I agree. But if it just checks whether the flex version is
>=2.5.4, it obviously "should not" fail on this flex version.
> And I'm pretty sure the check is in (perhaps when you run > ./buildconf though).
-- Best regards, Per Lundberg / Capio ApS Phone: +46-18-4186040 Fax: +46-18-4186049 Web: http://www.nobolt.com

Derick Rethans

23 years ago
On Thu, 17 Apr 2003, Per Lundberg wrote:
> On Thu, 2003-04-17 at 11:17, Derick Rethans wrote: > > On Thu, 17 Apr 2003, Per Lundberg wrote: > > > It doesn't warn me, and obviously, 2.5.31 > 2.5.4 so it should not... > > I should warn you, as 2.5.31 is borked. > > Yes, I agree. But if it just checks whether the flex version is > >=2.5.4, it obviously "should not" fail on this flex version.
again, it checks wheter the version is >=2.5.4 and NOT 2.5.31 Derick
-- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------

Per Lundberg

23 years ago
On Thu, 2003-04-17 at 11:43, Derick Rethans wrote:
> again, it checks wheter the version is >=2.5.4 and NOT 2.5.31
Actually, it checks whether the version is == 2.5.4. Maybe that was what you were trying to communicate. Anyway, I think a warning is not enough; it should bail out if the flex version is wrong (since it will not compile otherwise).
-- Best regards, Per Lundberg / Capio ApS Phone: +46-18-4186040 Fax: +46-18-4186049 Web: http://www.nobolt.com

Derick Rethans

23 years ago
On Thu, 17 Apr 2003, Per Lundberg wrote:
> On Thu, 2003-04-17 at 11:43, Derick Rethans wrote: > > again, it checks wheter the version is >=2.5.4 and NOT 2.5.31 > > Actually, it checks whether the version is == 2.5.4. Maybe that was > what you were trying to communicate. > > Anyway, I think a warning is not enough; it should bail out if the flex > version is wrong (since it will not compile otherwise).
If you'd been paying attention you'll notice that this was suggested a few days ago already. Derick
-- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------

Per Lundberg

23 years ago
On Thu, 2003-04-17 at 12:04, Derick Rethans wrote:
> On Thu, 17 Apr 2003, Per Lundberg wrote: > > Anyway, I think a warning is not enough; it should bail out if the flex > > version is wrong (since it will not compile otherwise). > If you'd been paying attention you'll notice that this was suggested a > few days ago already.
So why is it not done yet?
-- Best regards, Per Lundberg / Capio ApS Phone: +46-18-4186040 Fax: +46-18-4186049 Web: http://www.nobolt.com

Sebastian Bergmann

23 years ago
Derick Rethans wrote:
> I should warn you, as 2.5.31 is borked. And I'm pretty sure the check > is in (perhaps when you run ./buildconf though).
The check is in but doesn't abort ./configure as it IMHO should.
-- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

(Marcus Börger)

23 years ago
At 11:45 17.04.2003, Sebastian Bergmann wrote:
>Derick Rethans wrote: > > I should warn you, as 2.5.31 is borked. And I'm pretty sure the check > > is in (perhaps when you run ./buildconf though). > > The check is in but doesn't abort ./configure as it IMHO should.
I posted a patch already that abotrs make when the borked version 'would' be used. I disagree about aborting configure because you need flex/bison only when editing those source files and i guess only a few developers do. marcus

Per Lundberg

23 years ago
On Fri, 2003-04-18 at 12:35, Marcus Börger wrote:
> I posted a patch already that abotrs make when the borked version 'would' > be used. I disagree about aborting configure because you need flex/bison > only when editing those source files and i guess only a few developers do.
The code in CVS does not include the generated files, so anyone who wants to build CVS PHP need proper flex/bison. Still, adding it into the make might actually be better because it would handle the situation where configure is run with a proper version of flex/bison, but they are updated before the make is being run. But then again, this might not be wise because then basically many other checks should be done at compile-time as well...
-- Best regards, Per Lundberg / Capio ApS Phone: +46-18-4186040 Fax: +46-18-4186049 Web: http://www.nobolt.com

Sebastian Bergmann

23 years ago
Per Lundberg wrote:
> It doesn't warn me, and obviously, 2.5.31 > 2.5.4 so it should not...
The only supported version of flex at the moment is 2.5.4 (or 2.5.4a). The only supported versions of bison are 1.28, 1.35 and 1.75.
-- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/