[PATCH] Bug fix for #29770, but for PHP 4.3.9

php.internals

Vladimir Zidar

21 years ago
When safe_mode is set to 'on', popen() uses char buf[1024] to build argument list. This is not good, as it truncates command line without notice. This is NOT operating system limit - as noted on bugreport, but PHP bug. If anybody cares, here is fix for this bug under 4.3.9: http://leya.mindnever.org/~mr_w/php-popen.patch.gz PS, didn't have time to look at PHP 5 yet, but I suppose this fix could work also with minor tweaks.
-- Vladimir Zidar, Programmer MindNever Foodstuff TRDG. Head Office Branch Tel: +381-63-550161, +385-98-9574261 http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org

Andi Gutmans

21 years ago
This patch makes sense to me. Anyone have a problem with it? Andi At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote:

Wez Furlong

21 years ago
I'd feel slightly happier if it used spprintf() instead of manually calculating the buffer length, but otherwise I'm okay with it. --Wez. On Wed, 27 Oct 2004 09:51:52 -0700, Andi Gutmans <andi@zend.com> wrote:

Vladimir Zidar

21 years ago
I didn't know that such function exist. I can change my patch, and everybody should feel better.. ok ? On Wed, 2004-10-27 at 19:23, Wez Furlong wrote:
> I'd feel slightly happier if it used spprintf() instead of manually > calculating the buffer length, but otherwise I'm okay with it. > > --Wez. > > > On Wed, 27 Oct 2004 09:51:52 -0700, Andi Gutmans <andi@zend.com> wrote: > > This patch makes sense to me. Anyone have a problem with it? > > > > Andi > > > > > > > > At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote: > > > When safe_mode is set to 'on', popen() uses char buf[1024] to build > > > argument list. This is not good, as it truncates command line without notice. > > > This is NOT operating system limit - as noted on bugreport, but PHP bug. > > > > > > If anybody cares, here is fix for this bug under 4.3.9: > > > > > > http://leya.mindnever.org/~mr_w/php-popen.patch.gz > > > > > > PS, didn't have time to look at PHP 5 yet, but I suppose this fix could > > >work also with minor tweaks. > > > > > > > > >-- > > >Vladimir Zidar, Programmer > > > > > >MindNever Foodstuff TRDG. > > >Head Office Branch > > > > > >Tel: +381-63-550161, +385-98-9574261 > > >http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org > > > > > >-- > > >PHP Internals - PHP Runtime Development Mailing List > > >To unsubscribe, visit: http://www.php.net/unsub.php > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > >
-- Vladimir Zidar, Programmer MindNever Foodstuff TRDG. Head Office Branch Tel: +381-63-550161, +385-98-9574261 http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org

Vladimir Zidar

21 years ago
Here is version that uses spprintf() http://leya.mindnever.org/~mr_w/php-popen2.patch.gz On Wed, 2004-10-27 at 19:30, Vladimir Zidar wrote:

Andi Gutmans

21 years ago
Commited. At 08:46 PM 10/27/2004 +0200, Vladimir Zidar wrote: