Everything

php

Two minor issues in 5.0.4

php.internals

Antony Dovgal

21 years ago

Hi all!

I'd like to fix two minor issues before releasing 5.0.4.

These issues are:
1) mmap'ed files are bound to 2M.
In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in 5.0.4 it is set to 2000000.
That causes readfile() to read only 2Mb and stop (which is rather frustrating).
See main/php_streams.h

2) output_reset_rewrite_vars() *always* returns false.
See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re,
IMO it's just a silly typo, but this routine returns FAILURE in any case.
The very same problem actually exists in all other branches too

If nobody objects, I'll fix both issues in the evening.

--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com

Vadka

21 years ago

Hi all!

So, as it was stressed in expat one day, there are 'empty' tags, like:
<foo val=''/>
(without ending </foo>).
For now, it is not known what a tag was parsed (XML parser ext).
It is not good: the original structure of XML changes.

Davey

21 years ago

Vadka wrote:

>
> Hi all!
>
> So, as it was stressed in expat one day, there are 'empty' tags, like:
> <foo val=''/>
> (without ending </foo>).
> For now, it is not known what a tag was parsed (XML parser ext).
> It is not good: the original structure of XML changes.

In XML, <foo /> and <foo></foo> are identical as far as semantics are
concerned. This is nothing to worry about IMO - any decent XML parser
treats them the same.

- Davey

Antony Dovgal

21 years ago

On Sat, 26 Mar 2005 13:05:56 +0300
Antony Dovgal <antony@zend.com> wrote:

> Hi all!
>
> I'd like to fix two minor issues before releasing 5.0.4.
>
> These issues are:
> 1) mmap'ed files are bound to 2M.
> In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in 5.0.4 it is set to 2000000.
> That causes readfile() to read only 2Mb and stop (which is rather frustrating).
> See main/php_streams.h
>
> 2) output_reset_rewrite_vars() *always* returns false.
> See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re,
> IMO it's just a silly typo, but this routine returns FAILURE in any case.
> The very same problem actually exists in all other branches too
>
> If nobody objects, I'll fix both issues in the evening.

Ilia, Zeev, any objections?

--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com

Zeev Suraski

21 years ago

At 13:55 27/03/2005, Antony Dovgal wrote:

>On Sat, 26 Mar 2005 13:05:56 +0300
>Antony Dovgal <antony@zend.com> wrote:
>
> > Hi all!
> >
> > I'd like to fix two minor issues before releasing 5.0.4.
> >
> > These issues are:
> > 1) mmap'ed files are bound to 2M.
> > In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in
> 5.0.4 it is set to 2000000.
> > That causes readfile() to read only 2Mb and stop (which is rather
> frustrating).
> > See main/php_streams.h

Wez - is that safe to MFH it to the 5_0 branch
(http://www.mail-archive.com/php-cvs@lists.php.net/msg15050.html)?

> > 2) output_reset_rewrite_vars() *always* returns false.
> > See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re,
> > IMO it's just a silly typo, but this routine returns FAILURE in any case.
> > The very same problem actually exists in all other branches too
> >
> > If nobody objects, I'll fix both issues in the evening.

How are you planning to change it?

Zeev

Antony Dovgal

21 years ago

On Sun, 27 Mar 2005 14:51:09 +0200
Zeev Suraski <zeev@zend.com> wrote:

> How are you planning to change it?

See the diffs attached.

--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com

Zeev Suraski

21 years ago

The second diff appears to be pretty safe.  Let's see what Wez says on the
first one...

Zeev

At 14:57 27/03/2005, Antony Dovgal wrote: