Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » ext/calendar - New test scripts »

ext/calendar - New test scripts

php.internals

Rathna N

21 years ago
Sorry, I forgot to add subject line to the old mail. On Mon, 08 Aug 2005 23:56:24 -0700, "Rathna N" <nrathna@fastmail.fm> said:
> Hi All, > this is first my post to this list. > I'm interested to do QA related contributions to PHP. > > Pls do find the test scripts for Calendar extension at below links, > > http://www.geocities.com/rs81099/calendartest.zip > - contains the testscripts > > http://www.geocities.com/rs81099/calendarTestOutput.txt > - contains the test report on SUSE LINUX 9.2.1 > > I request you to review and commit the same, (If u r ok with the > scripts). > > Pls do pass on if u have any feedback to improve the quality of > TestScripts. > > Regards, > Rathna. > -- > Rathna N > nrathna@fastmail.fm > > -- > http://www.fastmail.fm - The professional email service >
-- Rathna N nrathna@fastmail.fm -- http://www.fastmail.fm - I mean, what is it about a decent email service?

Derick Rethans

21 years ago
On Tue, 9 Aug 2005, Rathna N wrote:
> Sorry, I forgot to add subject line to the old mail.
the php-qa@lists.php.net list would be the best list for this subject. As for the tests, it would be nice if you could provide a unified diff against CVS's HEAD. That's much easier than have to download a .zip file - we can more easily check the test cases then. Some points on the tests: - please always use lower case filenames for the tests. - as --TEST-- name, please just use the name of the function, such as "jdtojulian()" (without any other description) - try always to cover edge cases in your tests. (For gregorian times, it makes sense to check what it does around the beginning of the gregorian calendar for example). - prefer var_dump() over print_r(). - Always use the ISO 8601 format for outputting date (if you're formatting them yourself). See easter_date.phpt f.e. - In easter_date.phpt, you'll have to check way more years - just testing 3 is not enough. - There is no --DESCRIPTION-- field as you used in GregorianToJD.phpt. - Always use <?php and not <? in test cases (see JDToJulian.phpt). - Please stick to the PEAR coding standards in your tests. And thanks for picking this up! But perhaps I can suggest to start with other more used extensions? Most of our string and array functions don't have enough testcases either. regards, Derick
-- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org

Rathna N

21 years ago
thank you for the response. I will incorporate the feedback and send the updated ones. Regards, Rathna. On Tue, 9 Aug 2005 13:45:06 +0200 (CEST), "Derick Rethans" <derick@php.net> said:
> On Tue, 9 Aug 2005, Rathna N wrote: > > > Sorry, I forgot to add subject line to the old mail. > > the php-qa@lists.php.net list would be the best list for this subject. > As for the tests, it would be nice if you could provide a unified diff > against CVS's HEAD. That's much easier than have to download a .zip file > - we can more easily check the test cases then. > > Some points on the tests: > - please always use lower case filenames for the tests. > - as --TEST-- name, please just use the name of the function, such as > "jdtojulian()" (without any other description) > - try always to cover edge cases in your tests. (For gregorian times, it > makes sense to check what it does around the beginning of the > gregorian calendar for example). > - prefer var_dump() over print_r(). > - Always use the ISO 8601 format for outputting date (if you're > formatting them yourself). See easter_date.phpt f.e. > - In easter_date.phpt, you'll have to check way more years - just > testing 3 is not enough. > - There is no --DESCRIPTION-- field as you used in GregorianToJD.phpt. > - Always use <?php and not <? in test cases (see JDToJulian.phpt). > - Please stick to the PEAR coding standards in your tests. > > And thanks for picking this up! But perhaps I can suggest to start with > other more used extensions? Most of our string and array functions don't > have enough testcases either. > > regards, > Derick > > -- > Derick Rethans > http://derickrethans.nl | http://ez.no | http://xdebug.org
-- Rathna N nrathna@fastmail.fm -- http://www.fastmail.fm - mmm... Fastmail...

Rathna N

21 years ago
Comments incorporated and pls do find the cat of the patches and test report at the below links. http://www.geocities.com/rs81099/calendertests.txt - Contains the cat of test scripts patches. http://www.geocities.com/rs81099/phpCalendartestRep.txt - contains TesReport on SuSe 9.x If incase any issues with the above testscript files, zip can be found at http://www.geocities.com/rs81099/Caltestspatch.zip This week I'm planning to work on strings. Pls do pass on if u have any feedback. Regards, Rathna.
-- Rathna N nrathna@fastmail.fm -- http://www.fastmail.fm - A no graphics, no pop-ups email service