On 10.01.2006 19:13, Thiago Silva wrote:
> Hi,
> can anyone review this?
>
> It's a one-line patch for the silent operator (@), wich currently supress
> fatal error messages (undesirable for "@include" pehaps, wich makes difficult
> for debugging scripts).
With this patch you basically change whole @ functionality, thus breaking both BC and expected behavior in the same time.
And even in the case with include() - this is _expected_.
If you don't want to see all error messages silenced, just use set_error_reporting() to set desired error level.
> Index: Zend/zend_vm_execute.h
> ===================================================================
> RCS file: /repository/ZendEngine2/zend_vm_execute.h,v
> retrieving revision 1.62.2.23
> diff -u -r1.62.2.23 zend_vm_execute.h
> --- Zend/zend_vm_execute.h 4 Jan 2006 23:53:04 -0000 1.62.2.23
> +++ Zend/zend_vm_execute.h 10 Jan 2006 18:01:53 -0000
> @@ -434,7 +434,8 @@
> }
>
> if (EG(error_reporting)) {
> - zend_alter_ini_entry("error_reporting", sizeof("error_reporting"), "0", 1, ZEND_INI_USER, ZEND_INI_STAGE_RUNTIME);
> + /* 341 == E_COMPILE_ERROR|E_ERROR|E_CORE_ERROR|E_PARSE|E_USER_ERROR */
> + zend_alter_ini_entry("error_reporting", sizeof("error_reporting"), "341", 3, ZEND_INI_USER, ZEND_INI_STAGE_RUNTIME);
> }
> ZEND_VM_NEXT_OPCODE();
> }
--
Wbr,
Antony Dovgal
