RE: auto_globals_jit and register_argc_argv disconnect

php.internals

Dmitry Stogov

20 years ago
Hi Rasmus, Why you need "register_argc_argv" in your php.ini? Isn't CLI version sets it by default? Also, do we need this "register_argc_argv" for some SAPI except CLI, CGI and EMBED? Dmitry.

Rasmus Lerdorf

20 years ago
Dmitry Stogov wrote:
> Hi Rasmus, > > Why you need "register_argc_argv" in your php.ini? > Isn't CLI version sets it by default?
I don't really. My point was that it defaults to be on, so when you don't have a php.ini and just stick with the defaults, you will never get jit even though phpinfo will tell you it is turned on.
> Also, do we need this "register_argc_argv" for some SAPI except CLI, CGI and > EMBED?
Don't think so. -Rasmus

Dmitry Stogov

20 years ago
Understood. The patch is in attachment. Thanks. Dmitry.

Rasmus Lerdorf

20 years ago
Dmitry Stogov wrote:
> Understood. > The patch is in attachment.
Looks good. I'll run some tests. -Rasmus

Dmitry Stogov

20 years ago
Le me know about results of your tests. Then I probably will commit it. Dmitry.

Pierre Joye

20 years ago
On Wed, 15 Mar 2006 20:28:11 +0300 dmitry@zend.com ("Dmitry Stogov") wrote:
> Understood. > The patch is in attachment.
Not here, .txt? --Pierre

Dmitry Stogov

20 years ago
diff :) Dmitry.

Rasmus Lerdorf

20 years ago
By the way, we also have register_long_arrays on by default which also disables jit. So we are still in a position of basically nobody being able to use jit unless they really know what they are doing, or get lucky. Let's just turn register_long_arrays off. They are going away in PHP 6 anyway. -Rasmus Dmitry Stogov wrote:

Rasmus Lerdorf

20 years ago
Rasmus Lerdorf wrote:
> By the way, we also have register_long_arrays on by default which also > disables jit. So we are still in a position of basically nobody being > able to use jit unless they really know what they are doing, or get > lucky. Let's just turn register_long_arrays off. They are going away > in PHP 6 anyway.
Or rather, make them work with jit for now. Would be less disruptive, I suppose. -Rasmus

Dmitry Stogov

20 years ago
register_long_arrays cannot work with jit. Dmitry.

Nuno Lopes

20 years ago
> By the way, we also have register_long_arrays on by default which also > disables jit. So we are still in a position of basically nobody being > able to use jit unless they really know what they are doing, or get > lucky. Let's just turn register_long_arrays off. They are going away > in PHP 6 anyway. > > -Rasmus
At least it was documented: http://php.net/ini.core#ini.auto-globals-jit but now needs changing after Dmitry's commit :) Nuno