Everything

php

Home » Project » Newsgroups » php.internals » PDO, dbh::setDefaultFetchMode patch »

PDO, dbh::setDefaultFetchMode patch

php.internals

Pierre Joye

20 years ago

Hello,

This patch [1] adds a setDefaultFetchMode to the dbh object. It does
not introduce BC break but allow to set once the fetchmode for a
connection.

Comments?

--Pierre

[1] http://pear.php.net/~pierre/dbh_fetchmode.txt

Wez Furlong

20 years ago

It breaks the ABI; always add new structure members at the end of
structures, and always bump the API number when you change anything
like that in the pdo driver header file.

Aside from that, although I personally wouldn't use this patch, it looks OK.

--Wez.

On 3/18/06, Pierre <pierre.php@gmail.com> wrote:

Pierre Joye

20 years ago

On 3/19/06, Wez Furlong <kingwez@gmail.com> wrote:

> It breaks the ABI; always add new structure members at the end of
> structures, and always bump the API number when you change anything
> like that in the pdo driver header file.

Ok, not a problem to move it at the end.

> Aside from that, although I personally wouldn't use this patch, it looks OK.

It is for lazy coders like me ;-)

Ilia is fine to add it to 5.x (after 5.1.3), I will commit once 5.1.3
is released, head and to the active 5.x branche.

Thanks for the feedback :)

--Pierre