ext/filter, custom decimal separator, supports leading 0, regexp

php.internals

Pierre Joye

20 years ago
Hello, Due to the success on my precedent post, I try again to get some comments on my precedent patch and some new things I need in ext/filer. This patch adds or changes the following things: - regexp uses functions (ext/pcre) - 100% compatible with preg_* functions - Use of expression caches and other (faster) - Regexp tests now work - rewrite the filter_float - support custom decimal separator. Let the developer decides which separator to use, the default is not changed - slightly faster than the old implementation (and with the new features) The patch: http://pear.php.net/~pierre/filter_float_add_custom_seps_and_pcre.txt Some examples: http://pecl.php.net/~pierre/filter_float.phps Any ideas or comments are welcome, --Pierre

Antony Dovgal

20 years ago
+1 If we're going to make it the default way of handling user data, then it makes sense to implement it as flexible as possible, and regex stuff should be compatible with ext/pcre. On 10.04.2006 17:11, Pierre wrote:
> Hello, > > Due to the success on my precedent post, I try again to get some > comments on my precedent patch and some new things I need in ext/filer. > > This patch adds or changes the following things: > > - regexp uses functions (ext/pcre) > - 100% compatible with preg_* functions > - Use of expression caches and other (faster) > - Regexp tests now work > > - rewrite the filter_float > - support custom decimal separator. Let the developer decides which > separator to use, the default is not changed > - slightly faster than the old implementation (and with the new > features) > > The patch: > http://pear.php.net/~pierre/filter_float_add_custom_seps_and_pcre.txt > > Some examples: > http://pecl.php.net/~pierre/filter_float.phps > > Any ideas or comments are welcome, > > --Pierre >
-- Wbr, Antony Dovgal

Andrei Zmievski

20 years ago
I'll have to review it. -Andrei On Apr 10, 2006, at 6:31 AM, Antony Dovgal wrote:

Pierre Joye

20 years ago
On Mon, 10 Apr 2006 09:28:02 -0700 andrei@gravitonic.com (Andrei Zmievski) wrote:
> I'll have to review it.
For the record, the pcre part of the patch has been commited by Derick. --Pierre