Everything

php

Home » Project » Newsgroups » php.internals » curl_multi_info_read patch review »

curl_multi_info_read patch review

php.internals

Brian J. France

20 years ago

Some guys at work created this patch and have been running with it
for a while now.

Could I get a few more eyeballs on this?

http://www.brianfrance.com/software/php/curl_multi_read.patch

Quote from our internal bug:

"The attached patch implements curl_multi_info_read(), as well as
fixing some memory leak issues and reference problems in the original
source."

Should I keep it internal or commit it?

Thanks,

Brian

Sterling Hughes

20 years ago

please commit it, looks good.

thanks,
sterling

On 5/2/06, Brian J. France <list@firehawksystems.com> wrote:

Brian J. France

20 years ago

PHP_5_1 and head or just head?

It could be considered bug fix since curl_multi_info_read was there,
but not implemented.

Brian

On May 2, 2006, at 4:56 PM, Sterling Hughes wrote:

Sterling Hughes

20 years ago

not having tested it, i don't know.  this is certainly a RM question,
but if it doesn't break the compile, it does not look like it has the
potential to damage previously existing infrastructure.

-sterling

On 5/2/06, Brian J. France <list@firehawksystems.com> wrote:

Ilia A.

20 years ago

Apply this to HEAD for now, and once I'll review I'll give a you a go
ahead for PHP_5_2 branch that will be created. For now we'll just add
it to our 5.2 wiki TODO list.


On 2-May-06, at 5:29 PM, Brian J. France wrote:

> PHP_5_1 and head or just head?
>
> It could be considered bug fix since curl_multi_info_read was
> there, but not implemented.

Ilia Alshanetsky
Advanced Internet Designs Inc.
ilia@prohost.org

P.S. Sterling, you're alive!