Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » RC5 on Thursday »

RC5 on Thursday

php.internals

Ilia A.

19 years ago
The filter issue has been cleared up, as you can probably tell from my massive commit last night. Both of the protagonists of the discussion appear to be sufficiently mollified ;-), so its time to get back on track with the 5.2 release cycle. If all goes well this Thursday RC5 will be released and then followed by final release a week later. Ilia Alshanetsky

Edin Kadribasic

19 years ago
Hi all, We need to fix http://bugs.php.net/bug.php?id=38989 before the release. Some change has broken path handling on windows recently. Edin Ilia Alshanetsky wrote:

Pierre Joye

19 years ago
Hello, On 10/4/06, Edin Kadribasic <edink@emini.dk> wrote:
> Hi all, > > We need to fix http://bugs.php.net/bug.php?id=38989 before the release. > Some change has broken path handling on windows recently.
tsrm_virtual_cwd.c 1.74.2.9.2.3 is the last working version (http://cvs.php.net/viewvc.cgi/TSRM/tsrm_virtual_cwd.c?revision=1.74.2.9.2.3&view=markup&pathrev=PHP_5_2) There is a *lot* of changes, but as far as I can see, IS_ABSOLUTE_PATH is broken. It is used in expand_filepath, for example: "\\tmp\\test.txt" returns: before: C:\tmp\test.txt after: C:\phpbuilds\php_5_2\tmp\test.txt --Pierre

Pierre Joye

19 years ago
Hello, On 10/4/06, Pierre <pierre.php@gmail.com> wrote:
> Hello, > > On 10/4/06, Edin Kadribasic <edink@emini.dk> wrote: > > Hi all, > > > > We need to fix http://bugs.php.net/bug.php?id=38989 before the release. > > Some change has broken path handling on windows recently. > > tsrm_virtual_cwd.c 1.74.2.9.2.3 is the last working version > (http://cvs.php.net/viewvc.cgi/TSRM/tsrm_virtual_cwd.c?revision=1.74.2.9.2.3&view=markup&pathrev=PHP_5_2) > > There is a *lot* of changes, but as far as I can see, IS_ABSOLUTE_PATH > is broken. It is used in expand_filepath, for example:
Please find a possible fix as attachment, I did not test it intensivelly but it seems to work. Edin, can you take a look at it? It is actually a wonder that this kind of paths worked before Dmitry's commit :) --Pierre

Dmitry Stogov

19 years ago
I'll care about the problem. Thank you for patch. I'll review it. Dmitry.

Pierre Joye

19 years ago
Hello, On 10/5/06, Dmitry Stogov <dmitry@zend.com> wrote:
> I'll care about the problem. > Thank you for patch. > I'll review it.
I saw the commit, your fix sounds better. It takes of the possible different drive letters between php CWD and the system one. (5_2 commit looks weird ;) Thanks, --Pierre

Dmitry Stogov

19 years ago
Ogh... For some reson I changed line ending from CR to CRLF. Just changed it back. Sorry. Now I remebered what is wrong with WinCVS, and why I didn't use it several years. :( Dmitry.