Everything

php

pushing some more optimization patches

php.internals

Nuno Lopes

19 years ago

Hi,

I would like to push 2 more optimization patches onto the PHP tree:
* make arginfo const (and save memory):
http://mega.ist.utl.pt/~ncpl/zend_arginfo_const.txt (for php 5.2.1)
Trivial patch, which is expecially good for multi-core systems sharing the
same cache.

* use -fvisibility when using gcc 4:
http://mega.ist.utl.pt/~ncpl/php_gcc4_visibility.txt (for php 5.3/6)
this is a trickier patch and needs some tweaking in extensions exporting
their own API. The little hacks in the Apache SAPIs are needed because older
apache versions didn't know anything about gcc 4.

Any opinions or any volunteer to commit those patches? :)

Thanks,
Nuno

Ilia A.

19 years ago

On 9-Nov-06, at 12:08 PM, Nuno Lopes wrote:

> I would like to push 2 more optimization patches onto the PHP tree:
> * make arginfo const (and save memory): http://mega.ist.utl.pt/
> ~ncpl/zend_arginfo_const.txt (for php 5.2.1)
> Trivial patch, which is expecially good for multi-core systems
> sharing the same cache.

The first part looks fine, and if no one objects I'll commit it next
week.

> * use -fvisibility when using gcc 4: http://mega.ist.utl.pt/~ncpl/
> php_gcc4_visibility.txt (for php 5.3/6)
> this is a trickier patch and needs some tweaking in extensions
> exporting their own API. The little hacks in the Apache SAPIs are
> needed because older apache versions didn't know anything about gcc 4.

I'd prefer to hold off on adding to 5.2 series at this time, lets try
it out on 6.0 and if it works fine there perhaps port it back once
5.3 is on the table.


Ilia Alshanetsky

Nuno Lopes

19 years ago

>> I would like to push 2 more optimization patches onto the PHP tree:
>> * make arginfo const (and save memory): http://mega.ist.utl.pt/
>> ~ncpl/zend_arginfo_const.txt (for php 5.2.1)
>> Trivial patch, which is expecially good for multi-core systems  sharing
>> the same cache.
>
> The first part looks fine, and if no one objects I'll commit it next
> week.

OK, thanks.

>> * use -fvisibility when using gcc 4: http://mega.ist.utl.pt/~ncpl/
>> php_gcc4_visibility.txt (for php 5.3/6)
>> this is a trickier patch and needs some tweaking in extensions  exporting
>> their own API. The little hacks in the Apache SAPIs are  needed because
>> older apache versions didn't know anything about gcc 4.
>
> I'd prefer to hold off on adding to 5.2 series at this time, lets try  it
> out on 6.0 and if it works fine there perhaps port it back once  5.3 is on
> the table.

Sure. I didn't meant to push it to 5.2 as it can break some extensions
(although the fix is trivial).

Nuno

Andi Gutmans

19 years ago

The arginfo patch looks OK to me. Not sure about the visibility patch. I'll
try and look into it tomorrow.